durin42 added a subscriber: indygreg. durin42 added a comment.
> indygreg added inline comments. > > INLINE COMMENTS > >> wireprotov2server.py:602-605 >> + if 'default' in meta and meta.get('required'): >> + raise error.ProgrammingError('%s argument for command %s is marked ' >> + 'as required but has a default value' % >> + (arg, name)) > > Does this added check not address your review feedback, @durin42? No, actually - I was proposing *removing* `required` entirely, and *only* keying off the existence of a default. What you reduces us to only two valid states: required-with-no-default and not-required-with-default. I think we could make the specification of a default the thing that makes the argument optional. WDYT? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4615 To: indygreg, #hg-reviewers Cc: indygreg, durin42, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel