yuja added a comment.

  > @@ -319,7 +319,8 @@
  > 
  >   except Exception as e:
  >       action, meta = reactor.onservererror(
  >           outstream, command['requestid'],
  > 
  > - _('exception when invoking command: %s') % e) +            _('exception 
when invoking command: %s') % +            pycompat.sysbytes(str(e)))
  
  Nit: `stringutil.forcebytestr(e)` is better since it can handle platform
  strings.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D4731

To: indygreg, #hg-reviewers
Cc: yuja, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to