On Thu, Oct 18, 2018, 05:42 Yuya Nishihara <y...@tcha.org wrote: > On Wed, 17 Oct 2018 15:17:58 +0200, Boris FELD wrote: > > On 21/08/2018 15:15, Yuya Nishihara wrote: > > > On Mon, 20 Aug 2018 11:14:23 -0700, Martin von Zweigbergk via > Mercurial-devel wrote: > > >> On Mon, Aug 20, 2018 at 9:26 AM Kyle Lippincott <spect...@google.com> > wrote: > > >> > > >>> Bright/bold yellow should be considered unavailable. "Normal" > yellow, > > >>> which is closer to brown or maybe gold on many screens, is fine. > > >>> > > >> Ah, and we already use yellow for a few things (as you also pointed > out). > > >> Sorry I didn't even check that. > > >> > > >> > > >>> At Google, and I think other tools like clang, generally use > magenta I > > >>> believe, but I have no strong preference. Keep in mind that > ui.prompt is > > >>> also yellow a couple lines below. > > >>> > > >> Good point about ui.prompt. Yellow seems like the obvious choice for > > >> warnings, so do we want to change the color for the prompt? > > > FWIW, I don't like the red-colored "error" since it's hard to spot in > > > white-on-black screen. Well, it's readable, but not significant. A > plain > > > "yellow" (i.e. dark yellow) would have the same effect. > > > > I'm not sure what is the status of this series. > > > > Rereading the discussion, it seems like the yellow on white background > > is readable. Is there anything else blocking this improvement > > I'm not sure either, but for the record, I (and maybe David Demelier) voted > against this. I want an essential part of console output to be white > because > that's what I configured for. I'd rather want warning/error messages to be > prefixed with highlighted tags (e.g. <red>abort:</red> blah blah...) >
I'm for the patch. I also agree with Yuya that it would be better to color only a short prefix. That's probably a lot more work and can be done in a follow-up. However, I understand if Yuya and others think it's too distracting with all the color before that is done, so I'm also fine with waiting until that's fixed. Do we have a common prefix for warnings?
_______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
