durin42 added inline comments.
INLINE COMMENTS
> store.py:39
> + elif path.startswith('meta/'):
> + return matcher.visitdir(path[len('meta/'):-len('/00manifest.i')] or
> '.')
> +
Please follow up with a patch that raises ProgrammingError at the end of this
function - right now you just magically return False if you don't recognize the
path, which feels dangerous.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D5139
To: pulkit, durin42, #hg-reviewers
Cc: mjpieters, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
