yuja added a comment.
> > This is logically incorrect. The problem is that we're doing variable > > expansion at too lower layer. `vfs(expand(user_specified_path))` makes > > some sense, but `vfs(expand(getcwd()))` is clearly wrong. And the vfs class > > can't know where the `base` comes from. > > If I add a condition for expanding env var if present in `hgrc`, can this work as a fix? Maybe no. Where do you intend to add such code? vfs doesn't know where the path comes from. Neither does localrepo. > If the only solution for this is shifting path expansion from `vfs` class, where do you > think it can be? Somewhere specifying repository path read from hgrc or user input. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5503 To: navaneeth.suresh, #hg-reviewers Cc: yuja, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
