yuja added subscribers: lothiraldan, yuja. yuja added a comment.
> + bases = self._common.bases > + if callable(bases): > + # This happens for Rust exported object, and we don't know > + # at the moment how to make an equivalent of property for them > + bases = bases() > + > > 1. The presence of nullrev will confuse heads(). So filter it out. return set(self._repo.revs('heads(%ld)', > - self._common.bases - {nullrev})) + (r for r in bases if r != nullrev))) @lothiraldan Any idea on how to make this less ad-hoc? If we'll never need bases of set type, maybe we can add `baseslist()` to both Python and Rust implementations. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5551 To: gracinet, indygreg, #hg-reviewers Cc: yuja, lothiraldan, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel