philpep marked 3 inline comments as done. philpep added inline comments. INLINE COMMENTS
> mharbison72 wrote in phabricator.py:187 > s/.encoding/.environ/ ? Woops... Thanks for catching this! > mharbison72 wrote in phabricator.py:200 > Should this be using vfs to open, instead of raw open? Using the vfs layer > allows the class that provides posix-like functionality on Windows to be used. Yes, done. > mharbison72 wrote in phabricator.py:290 > It might be clearer to return None, since the function is to fetch the repoid. Indeed, I fixed this. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D5299 To: philpep, #hg-reviewers Cc: mharbison72, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
