martinvonz requested changes to this revision.
martinvonz added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ngoldbaum wrote in help.py:689-695
> I left this as-is because I find for-else statements hard to read (I never
> remember what it means!) and find this to be clearer even if there's a bit
> more boilerplate.
I avoid for-else for the same reason, but how about this:
if not any(subtopic in names for names, header, doc in subtopics[name]):
raise error.UnknownCommand(name)
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D6441
To: ngoldbaum, #hg-reviewers, martinvonz
Cc: martinvonz, av6, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
