martinvonz added inline comments.

INLINE COMMENTS

> taapas1128 wrote in state.py:215
> the special handling is given so that `checkunfinished()` and 
> `clearunfinished()` bypass `bisect` completely.(see line 93 D6501 
> <https://phab.mercurial-scm.org/D6501> the comment above unfinishedstates)  
> And reportonly flag is not required because for `morestatus`  uses 
> `getrepostate()` which is itself a report only feature.

Note that I didn't suggest changing `getrepostate()` -- I said (or tried to 
say) that I would like `checkunfinished()` and `clearunfinished()` to not have 
handle bisect specially.

> taapas1128 wrote in test-graft.t:282
> that is done in D6504 <https://phab.mercurial-scm.org/D6504>. Do you want me 
> to fold that here?

I thought we had agreed (at least Pulkit seemed to agree with me) to add a 
third argument for the multi-line message for verbose status. That should mean 
that no tests would need to change.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6503/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6503

To: taapas1128, durin42, #hg-reviewers, martinvonz
Cc: mjpieters, martinvonz, pulkit, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to