joerg.sonnenberger added inline comments. joerg.sonnenberger marked 2 inline comments as done.
INLINE COMMENTS > indygreg wrote in bundlerepo.py:642 > Something I didn't notice before is that this function doesn't do any UI > presentation. So it feels like a bug to print a message in this function > assuming that fetched changesets will be displayed. > > I suppose that means we'll need to include the "was partial reply" state in > the return value and format it to a warning elsewhere. > > Sorry for not catching this on first review. I intend to queue this patch for > stable so it gets in the 5.0 release, as I think the improved UI is good to > have. We know that this whole code fragment for "incoming" is seriously limited and should go away. Do we really want to change the whole API for that one special use case? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6267/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6267 To: joerg.sonnenberger, #hg-reviewers, indygreg Cc: indygreg, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
