navaneeth.suresh added inline comments.
navaneeth.suresh added a subscriber: yuja.

INLINE COMMENTS

> marmoute wrote in test-config.t:232
> the `(default: False)` should be `(default: no)` too.

that change was there in my patch one revision before. i was asked by @pulkit 
to modify it as of now. would you recommend writing `no` to `fm.data()` also? 
the `defaultvalue` was not in `pycompat.bytestr()` after @yuja's suggestion. it 
would be better if we consider that as a string and change the function 
accordingly if we want to modify it. otherwise, it should print  `no` and store 
`False`, print `False` on `hg showconfig --Tjson` in `defaultvalue`.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6709/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6709

To: navaneeth.suresh, #hg-reviewers, av6, marmoute
Cc: yuja, pulkit, marmoute, av6, mjpieters, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to