av6 added inline comments.

INLINE COMMENTS

> ui.py:832
> +                    # Omit config items with dynamicdefault, devel,
> +                    # experimental and generic config opts.
> +                    continue

Nit: originally I was fine with two different `if ...: continue` blocks here, 
and I still think it would be better. Not only the condition here is fairly 
complex and spans multiple lines (so not easy to read), but this comment is not 
quite correct. We always omit items with dynamic defaults and generic items, 
but experimental (& etc) items are only omitted unless --verbose is given. Two 
comments in two if-blocks with two separate conditions here would be more 
readable.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D6709/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D6709

To: navaneeth.suresh, #hg-reviewers, av6, marmoute, durin42
Cc: durin42, mharbison72, yuja, pulkit, marmoute, av6, mjpieters, 
mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to