dlax added inline comments. INLINE COMMENTS
> templateutil.py:114 > > + __metaclass__ = abc.ABCMeta > + This is ignored on Python 3 (meaning it's possible to instantiate `mappable` directly, despite some methods being abstract). It should be `class mappable(metaclass=abc.ABCMeta)` on Python 3. But I realize that there are other `__metaclass__ = abc.ABCMeta` in the code base. Do we handle this somehow or has this been overlooked? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7262/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7262 To: durin42, #hg-reviewers, indygreg Cc: dlax, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
