marmoute added a comment. marmoute requested review of this revision.
In D7324#107591 <https://phab.mercurial-scm.org/D7324#107591>, @indygreg wrote: > The code is fine. But since I've already left a number of comments on this series, I thought I'd ask about raising a better exception than `RevlogError`. I thought we had dedicated exceptions for revision not existing? This is the exception currently raised by nodemap access and recognised by higher level code (that turn it into a better exception). Maybe this should change ? but this is out of scope from this series in my opinion. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7324/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7324 To: marmoute, indygreg, #hg-reviewers Cc: mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
