mharbison72 added inline comments.

INLINE COMMENTS

> dlax wrote in filemerge.py:122
> What about `fctx`? It could also lack the `ctx()` method if an instance of 
> `absentfilectx`.
> I wonder if the intent was not `fctx.changectx() == self.changectx()`.

I’m not sure how this works, but this was enough to make pytype happy.  Does it 
make any sense to compare an absent file to an absent file?

Maybe the right thing is to add a ctx attribute here?

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7465/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7465

To: mharbison72, #hg-reviewers
Cc: dlax, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to