pulkit added a comment.

  In D7649#113454 <https://phab.mercurial-scm.org/D7649#113454>, @martinvonz 
wrote:
  
  > In D7649#113440 <https://phab.mercurial-scm.org/D7649#113440>, @pulkit 
wrote:
  >
  >> I am bit confused with `/repo` everywhere that whether that's the only 
valid or other forms can be valid also. I will prefer making existing root 
passed as absolute instead of replacing them with `/repo` (provided I 
understood correctly).
  >
  > I switched to `/repo` only to try to clarify that the path is the path to 
the repo (not some subdirectory). Want me to switch them back?
  
  Yes, that will be much appreciated.

INLINE COMMENTS

> match.py:155
>      arguments:
>      root - the canonical root of the tree you're matching against
>      cwd - the current working directory, if relevant

We can mention here that it must be an absolute path.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7649/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7649

To: martinvonz, #hg-reviewers, mharbison72
Cc: pulkit, mharbison72, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to