pulkit added inline comments. INLINE COMMENTS
> convcmd.py:58 > > +def readauthormap(ui, authorfile, authors={}): > + with open(authorfile, b'rb') as afile: We disallow usage of default mutable arguments. Hence `test-check-code.t` says hi. + hgext/convert/convcmd.py:58: + > def readauthormap(ui, authorfile, authors={}): + don't use mutable default arguments REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7732/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7732 To: joerg.sonnenberger, #hg-reviewers Cc: pulkit, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel