Alphare added inline comments. INLINE COMMENTS
> martinvonz wrote in matchers.rs:166 > This will often be called repeatedly, so isn't it better to calculate a map > of each parent directory to its `VisitChildrenSet` value upfront (in > `FilesMatcher::new()`)? Agreed. In much of this series there exist opportunities for caching/making things run in parallel, etc. With the freeze approaching really fast, I prefer to prioritize getting correct - albeit sub-optimal - code in rather than risking missing the deadline. My benchmarks of the entire series show an improvement in bare `hg status` in all supported repositories (read: that don't have back-references in their `.hgignore patterns), and no measurable slowdown in others. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7914/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7914 To: Alphare, #hg-reviewers Cc: martinvonz, durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
