martinvonz added inline comments. INLINE COMMENTS
> nodemap.py:42 > + raise error.ProgrammingError( > + "cannot persist nodemap of a filtered changelog" > + ) need b'' here and below for py3? > nodemap.py:49 > + # EXP-TODO: if this is a cache, this should use a cache vfs, not a > + # store vfs > + with revlog.opener(revlog.nodemap_file, 'w') as f: and here? this is a series that introduced a lot of new code, so try running all (previously passing) py3 test at least at the end of the series REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7835/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7835 To: marmoute, indygreg, #hg-reviewers Cc: martinvonz, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
