martinvonz added inline comments. INLINE COMMENTS
> gracinet wrote in node.rs:226 > yes, indeed. > > current callers from `nodemap` work either on full Nodes or (the visitor) by > explicitely bounding with `prefix.len()`, but it's safer to protect it > inconditonally. > > I think a simple `assert!` is enough though: that's already what slicing does > anyway. Yes, an `assert!` is probably what I had in mind. I've already queued this, so please send in a follow-up. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7790/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7790 To: gracinet, #hg-reviewers, martinvonz Cc: martinvonz, durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
