yuja added a comment.

  > {
  >
  >     if (getenv("CHGDEBUG"))
  >             enabledebugmsg();
  >
  > @@ -429,7 +431,7 @@
  >
  >             hgc = connectcmdserver(&opts);
  >             if (!hgc)
  >                     abortmsg("cannot open hg client");
  >
  > - hgc_setenv(hgc, envp);
  >
  > +           hgc_setenv(hgc);
  
  I prefer passing in (const char**)environ to hgc_setenv().

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8021/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8021

To: spectral, #hg-reviewers
Cc: yuja, pulkit, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to