marmoute added inline comments. INLINE COMMENTS
> martinvonz wrote in nodemap.py:47-49 > The actual semantic of this code (the Python code) is to serialize the data. > To me, "persist" implies writing it to disk, which is not what this code > does. I think it's just misleading to call it that even if the Rust code will > actually be writing directly to disk. On my side, I feel like `serialize` is misleading because this is not meant to have a "deserialization" phase taht reconstruct the data in memory. Can we wait for the bulk of the code to be in before we decide on a name and do a (simpler) changeset to align things to the naming scheme? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7834/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7834 To: marmoute, #hg-reviewers, martinvonz Cc: martinvonz, mjpieters, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
