martinvonz added inline comments.

INLINE COMMENTS

> hg_path.rs:195
> +    pub fn parent(&self) -> &Self {
> +        let inner = self.as_bytes();
> +        HgPath::new(match inner.iter().rposition(|b| *b == b'/') {

Might be good to add an `assert!` here in case my assertion (that `HgPath` 
should never have a trailing `/`) is not correct.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D7867/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D7867

To: Alphare, #hg-reviewers, kevincox, pulkit, martinvonz
Cc: martinvonz, durin42, kevincox, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to