Alphare added inline comments. INLINE COMMENTS
> martinvonz wrote in files.rs:207-216 > Might be worth having a fast path for when `name` is not absolute (including > "") and neither `name` nor `cwd` contains "../"so we don't do `let name = > root.join(&cwd).join(&name)` immediately followed by `let name = > name.strip_prefix(&root).unwrap()`. Especially since that seems like the > common case. Or can that ever produce different results? Anyway, that can be > done later. That might be worth investigating indeed. I will defer to a later time, though. :) > martinvonz wrote in files.rs:220-222 > Is this accurate? It looks like we break when `name.parent() == None`. I could reword this sentence if you feel that it does not convey the same meaning. It fits the Python implementation better, that's for sure. > martinvonz wrote in files.rs:227-230 > `name.components().next()` will be `None` only if `name` is something like > "/", right? But then we shouldn't return "" (a repo-relative path), we should > error out. For `b'/'` it would return `Some(std::Path::Components::RootDir)`. It only returns `None` if there are no components. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7871/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7871 To: Alphare, #hg-reviewers, kevincox, martinvonz Cc: martinvonz, durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
