spectral added inline comments. INLINE COMMENTS
> mharbison72 wrote in bundle2.py:1018 > Aren't `self.__class__.__module__` and `self.__class__.__name__` str? Yep, so this instance fails for other reasons as well. Sigh. I've sent a followup (D8091 <https://phab.mercurial-scm.org/D8091>). This may cause output like <foo object at 0xabcd1234; id: b'id'; type: b'type'; mandatory: True>. I didn't actually test most of these, obviously :P I just did a grep for __repr__ returning bytes... REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8089/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8089 To: spectral, #hg-reviewers, marmoute Cc: mharbison72, marmoute, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
