pulkit added a comment.
Nice! Looks good to me. Can you add a releasenotes entry in `relnotes/next`? INLINE COMMENTS > purge.py:51 > (b'', b'all', None, _(b'purge ignored files too')), > + (b'i', b'ignored', None, _(b'purge only ignored files')), > (b'', b'dirs', None, _(b'purge empty directories')), nit: Here instead of `None`, `False` can be used to prevent passing default value later in line 110. > purge.py:112 > + unknown = not ignored > + cmdutil.check_at_most_one_arg(opts, b'all', b'ignored') > nit: it's better to have the check earlier, i.e. after line 99 on this side. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D8096/new/ REVISION DETAIL https://phab.mercurial-scm.org/D8096 To: valentin.gatienbaron, #hg-reviewers, marmoute Cc: pulkit, marmoute, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
