This revision now requires changes to proceed. durin42 added a comment. durin42 requested changes to this revision.
I'm just not comfortable with the `unsafe` block here, especially with the comments from @kevincox . That said, if the `unsafe` can't disappear, it probably needs a pretty thorough explanation of why it's correct for a novice rust reader to follow? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7796/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7796 To: gracinet, #hg-reviewers, kevincox, durin42 Cc: marmoute, durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
