marmoute added a comment.
In D7795#120551 <https://phab.mercurial-scm.org/D7795#120551>, @durin42 wrote: > In D7795#119774 <https://phab.mercurial-scm.org/D7795#119774>, @marmoute wrote: > >> The change seesm good to me. However kevincox proposal to use `#[cfg(test)]` for `pad_node` seems worth applying inflight. > > For future reference, I'm going to add it here, but if you're going to the trouble of uploading a new revision, it would have been nice to do this and save reviewer toil. I juste rebased the revision on a more modern tip. I did not actually touched anything inside it. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7795/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7795 To: gracinet, #hg-reviewers, kevincox, marmoute Cc: marmoute, durin42, kevincox, mercurial-devel _______________________________________________ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
