marmoute added inline comments.

INLINE COMMENTS

> martinvonz wrote in commands.py:2339
> Hmm, do we do that elsewhere? It would seem out of place to me, but if 
> there's precedent for doing it, I can do it here too.

The other command with variable number of arguments I can think of usually mark 
them as optional in their synopsis (eg: `hg bookmarks`), but I feel like the 
situation in a bit different.

The new doc is clearer, but still not very clear. Can you try adding the 
synopsis to see how it looks like?

An alternative is to augment the help test to support multiple synopsys, "it 
can't be that hard".

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8029/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8029

To: martinvonz, #hg-reviewers, durin42, marmoute
Cc: pulkit, durin42, marmoute, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to