Alphare added inline comments.

INLINE COMMENTS

> kevincox wrote in dirstate_map.rs:251
> You should be able to use `.as_mut()` just like you are currently doing in 
> the caller.

`as_mut()` only does `&mut Option<T> -> Option<&mut T>`, which isn't always 
what we want (however you can argue that it would save a few keystrokes), but 
calling `unwrap()` circles back to the same `error[E0515]: cannot return value 
referencing temporary value`.

REPOSITORY
  rHG Mercurial

CHANGES SINCE LAST ACTION
  https://phab.mercurial-scm.org/D8110/new/

REVISION DETAIL
  https://phab.mercurial-scm.org/D8110

To: marmoute, #hg-reviewers, Alphare
Cc: Alphare, kevincox, mercurial-devel
_______________________________________________
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

Reply via email to