Hi,

I've just pulled some very nice changesets from Steeven
(http://bitbucket.org/steeven/my-work-for-mercurialeclipse/overview/)
for importing/exporting diffs. They are now in our main line on
Assembla. Good work Steeven! I got two remarks, though:

- When you contribute in the future (and I really hope that you will
continue your excellent work), please only use local tags to tag your
changesets, as we normally only use global tags on releases.

- Please move the Clipboard code out of HgPatchClient - we try to get
rid of SWT/Eclipse dependencies in this package in order to facilitate
automatic tests of our HgXXXClients. The client should only return
custom MercurialEclipse objects or the raw Mercurial output. I know that
we still have a lot of IResource references cluttering this package, but
I'd rather have the Eclipse dependencies out of it rather sooner than
later :).

I can only repeat myself: I'm kinda shocked how nicely these wizards
integrate into Eclipse - be it the import / export from clipboard or the
usage of the Eclipse resource chooser when using a workspace location.

Thanks,
Bastian

Attachment: signature.asc
Description: Dies ist ein digital signierter Nachrichtenteil

Reply via email to