El 28/08/2009 04:01 p.m., Greg Ward escribió: > > Good news: I got a custom build of MercurialEclipse to work by > installing it manually, as suggested by Andrei Loskutov. Thanks > Andrei! > > Bad news: MercurialEclipse conflicts with the crecord extension, at > least on my machine. It looks like setting LANG=en is a bad idea. > Command-line example: > > $ LANG=en hg log -r. -l1 > *** failed to import extension crecord from > /home/gward/.hgext/crecord: unsupported locale setting > changeset: 1238:2ed3531b5849 > user: iloveeclipse > date: Fri Aug 28 07:51:48 2009 +0200 > summary: Allow untracked resources to be shown in commit dialog > > Note that crecord fails to import, but the 'hg log' command is > successful other than that. I think this is a bug in crecord, but log > itself is fine.
Yep, I think so too. It's a bug in crecord and should be filed there. Just think of all the people that don't use plain english characters - e.g. russion, spanish, german, ... > > 1) redundant error reporting; the dialog tells me the same thing 3 > times before getting to the real problem Yep, not nice. > > 2) failure to load one extension does not mean Mercurial is broken; > IMHO it would be safe to ignore the "*** failed to import extension > ..." message and parse the rest of Mercurial's output So how should we know what is okay and what not. Maintaining a list of extensions that are known or okay to fail doesn't seem desirable to me. And there are some failures that *are* important. But basically we assume your Mercurial install is fine - I don't think we should ignore these errors, as they are failures in the Mercurial configuration or in used plugins. > > 3) no indication of how to reproduce the problem; I had to dig into > the source code for MercurialEclipse to figure out what it was doing > and understand the problem. It would be nice to know 1) what > environment vars are set, 2) what command was run, and 3) what > directory it was run from. The MercurialEclipse console shows the commands. You just need to open it to see it. One could output all the debug information when debug information is enabled in the preferences, right now, only the complete Mercurial output is shown in addition to the command issued. > > I found a workaround for the crecord bug: just set LANG=C rather than > "en". At least that works on my Linux box. But IMHO the real bug us > #2 above; just because some extension is broken does not mean that > Mercurial is broken. I would submit a patch, but I can't find where > in the code that error is generated. Hints? MercurialEclipse uses the project resp. the platform encoding specified in your project settings. Setting LANG=C generally doesn't work because of other locales as mentioned above. > > Greg > > P.S. I have made myself a fork on bitbucket, so I'll send a patch to > set LANG=C there in a moment. But IMHO that's just a workaround for > someone else's bug, not the real fix. Yeah, I would strongly vote against including something like this in main, as there a ton of people that would suffer from not being able to use their locale. Best regards, Bastian > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "MercurialEclipse" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/mercurialeclipse?hl=en -~----------~----~----~----~------~----~------~--~---
