I'm testing that Andrei fixed issue #243, which I reported last week.
Looks good, but I noticed that there might be room for more optimizing
there. Specifically, the Mercurial Console reveals that the following
commands are run when I first open "Switch To...":
1) /home/gward/src/mercurialeclipse/hg status -mard
2) /home/gward/src/mercurialeclipse/hg parents --template {rev}
3) /home/gward/src/mercurialeclipse/hg log --debug --style
/home/gward/workspace/.metadata/.plugins/com.vectrace.MercurialEclipse/log_style
-l 500
4) hg help --config extensions.hgext.bookmarks= bookmarks
5) /home/gward/src/mercurialeclipse/hg bookmarks --config
extensions.hgext.bookmarks=
Commands 1..3 are obviously needed, so no complaint there.
Command 5 will be necessary if I click the "Bookmarks" tab, but not
until then. The other tabs do the right thing: e.g. it only runs 'hg
tags -v' when I click "Tags", not sooner.
Command 4 makes no sense, unless it's to test that the bookmarks
extension can be activated. (But it's inconsistent about how it runs
hg: the other commands use the exact path, and #4 trusts $PATH to do
the right thing.) But if bookmarks cannot be activated, then Command
5 will fail regardless. Why waste valuable time (>0.1 sec on my
machine, and I imagine it's worse on Windows) spawning an unnecessary
child process?
Greg
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"MercurialEclipse" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/mercurialeclipse?hl=en
-~----------~----~----~----~------~----~------~--~---
