As a followup to this, the fix for the qimport bug is to remove the "--name"
from the command in HgQImportClient.

I've found qpop does work, but like qpush relies on having a patch selected
to pop to, it won't pop anything if no patch is selected.  Both these
behaviors seem very unintuitive at least to me.

Another confusing issue with the UI is the statusLabel output.  This only
seems to be updated at the beginning, when the hg root changes, or when an
exception occurs executing a command.  Once the exception occurs the status
continues to display the same message even after new, successfully commands
are issued.  Because it is limited to one line out output, if say qpush
fails with invalid hunks the only feedback is the status bar now reads
'applying patchname'.  The failed hunks are not applied, but hgqueues
considers the patch itself to be applied - however populateTable is not
called when an exception occurs, so until something else causes
populateTable to be called the view is not update to reflect changes.
Perhaps a dialog with the full message would be a more useful way to present
errors here, and/or a patch status akin to FAILED or PARTIALLY APPLIED.

As I get time I'm happy to work on a fix that would address some or all of
these issues, but want to make sure there is interest in the changes first.

-Mike

--

You received this message because you are subscribed to the Google Groups 
"MercurialEclipse" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/mercurialeclipse?hl=en.


Reply via email to