Hi all,
I have successfully set up an environment and compiled a version of
MercurialEclipse in which I have fixed this issue that I had reported some time
ago.
Following that (rather painful) process, I'd like to make the following
comments and suggestions.
* The README.md file should mention that the javahg projects should be
compiled with tests skipped: the 'javahg' project (0.8-snapshot) build with
"mvn install" simply fails, with both Mercurial 1.9.3 and Mercurial 2.9.
Success here is however necessary for javahg-ext-rebase since that project
seems to be looking for "javahg-0.7-tests.jar" in the local repository despite
the dependency having a "test" scope and tests being disabled. Maybe it's an
m2e problem.
* I had to deceit Maven by copying "javahg-0.7.jar" and renaming it to
"javahg-0.7-tests.jar" before the javahg-ext-rebase build could succeed.
* After all 5 javahg dependencies where built and installed, I've
exported the plugin in a 2.1.1 version to replace the
"com.vectrace.MercurialEclipse_2.1.0.201304290948.jar" that was in my Eclipse's
"plugins" folder.I've removed the old file and pasted the exported plugin jar.
After I've started it up, Eclipse reports in the Error log that it wasn't able
to instantiate the plugin. Apparently, what I did with that pasting and
removing is incorrect. How do we replace the version of MercurialEclipse that
was installed via the update site with our modified version of the plugin?
* The readme file says that there are two projects, "feature" and
"plugin". There are actually four folders in the cloned repository, the two
that are mentioned, plus "feature-m2e" and "plugin-m2e". This is confusing.
Moreover, what should we do with the "feature" project? What is it for? How do
we use it?
I suggest the file be updated with a clear instruction set that any developer
could follow even if they are, like me, unfamiliar with Eclipse plugin
development and BitBucket cloning/branching/etc. Even better, the dependencies
artifacts could be uploaded to a public repository. Maybe the sonatype-ossrh
repository that shows up in the error log?
About that issue that I've fixed: I am not submitting a patch (see the link)
because I've realized just seconds ago that when paths contain non-ASCII
characters such as "é", the files below that folder are colored/decorated as if
they were ignored, i.e. the getStatus function returns null for the files,
probably because of an encoding incompatibility. Although this will only affect
users that have diacritical signs in file paths, the fix can't be used as is. I
have however explained on the linked page the causes of the issue. I hope the
explanations (1- bad character case in colorDefinition and fontDefinition
labels for ignored files and 2- the fact that ignored files apparently don't
make it into the status cache) will be useful to someone in the development
team.
Best regards,
-Amenel.
--
You received this message because you are subscribed to the Google Groups
"MercurialEclipse" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/d/optout.
