FIX : GeoTagged images are now drawn to the full size of GeoImageDock
Timo Schlüßler wrote:
Yves Goergen wrote:
Here's the things that didn't work out very well:
Readonly layers are asked to be made writeable when loading geotagged
images to them (rev 13943): This is not acceptable actually, sorry. I'm
glad we now have read-only layers and track layers are read-only by
default (at option), but when I want to load my photos into it, I need
to make it writeable again. Why that? Can't the photos be added to a
read-only layer? Or at least can't the layer be made read-only again
after loading the photos? And could that new warning message please go
away then?
The problem here is that you have to select the trackpoint which owns an
image in order to display it in the GeoImageDock. If the layer is
readonly, you can't select the trackpoints and therefore you will never
see images loaded to readonly layers.
GeoImage trackpoints drawn differently (rev 13926): I didn't understand
the change log entry. But the effect is that I cannot see my photos on
the track layer anymore. Very few of them have a generic "there's
something on this node" icon but most are just invisible. The black
rectangle before was there for every photo, now it's gone. This is a
critical bug that needs to be fixed for a release.
The aim of using a "different drawing of GeoImage trackpoints" was to
avoid changes in the TrackPoint class. The old way of drawing the
rectangle about the trackpoints was to check if TrackPoint::imageId is
set and then draw the rect from within the paintEvent. The "new" way
uses merkaartor Styles: All trackpoints having an image have the tag
'Picture' = 'GeoTagged' set and I thought it would be a good idea to
make the style paint an image on all trackpoints that have that tag set.
Now TrackPoint.cpp doesn't have to hold extra variables and methods
(like imageId) and another advantage is that the form, color, size,...
of the rectangle can be controlled by the styles.
GeoImage dock zoom improved: Yes, it feels a lot better now. But it
doesn't fill all the available space in the dock window. The image ends
a bit left of the right end. Also when zoomed in or panned. This wasn't
like it before.
I changed nothing in that, it was so since the beginning of
GeoImageDock. But you are right that it would be a nice thing to fill
the whole space. I will work on that.
GeoImage dock paints with anti-alias: Couldn't test this because I
didn't find suitable photos on the track.
The antialias effect is always visible when you zoom in a lot. Without
antialiasing you could then see the single pixels, with antialiasing you
then see a blurred mix of the pixel-colors.
Thanks for your tests and critics so far.
Timo
_______________________________________________
Merkaartor mailing list
Merkaartor@openstreetmap.org
http://lists.openstreetmap.org/listinfo/merkaartor
_______________________________________________
Merkaartor mailing list
Merkaartor@openstreetmap.org
http://lists.openstreetmap.org/listinfo/merkaartor
