Module: Mesa Branch: staging/20.0 Commit: cde6f3c122dccb3ed6adf0560925ee530810c298 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cde6f3c122dccb3ed6adf0560925ee530810c298
Author: Danylo Piliaiev <[email protected]> Date: Tue Apr 21 18:20:39 2020 +0300 spirv: Expand workaround for OpControlBarrier on old GLSLang In SPIRV of compute shader in Aztec Ruins benchmark there is: OpControlBarrier %uint_1 %uint_1 %uint_0 // ControlBarrier(Device, Device, rdcspv::MemorySemantics(0)); which is an incorrect translation of glsl barrier(). GLSLang, prior to c3f1cdfa, emitted the OpControlBarrier with Device instead of Workgroup for execution scope. 2365520c covers similar case but isn't applied when execution_scope is SpvScopeDevice. Cc: <[email protected]> Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/2742 Signed-off-by: Danylo Piliaiev <[email protected]> Tested-by: Rafael Antognolli <[email protected]> Reviewed-by: Caio Marcelo de Oliveira Filho <[email protected]> Reviewed-by: Jason Ekstrand <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4660> (cherry picked from commit 66229aa16968eb60dd631a8f48f593a4fa8478d5) --- .pick_status.json | 2 +- src/compiler/spirv/spirv_to_nir.c | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/.pick_status.json b/.pick_status.json index 0eb11a276cb..fde12b08aa3 100644 --- a/.pick_status.json +++ b/.pick_status.json @@ -256,7 +256,7 @@ "description": "spirv: Expand workaround for OpControlBarrier on old GLSLang", "nominated": true, "nomination_type": 0, - "resolution": 0, + "resolution": 1, "master_sha": null, "because_sha": null }, diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c index 3c05d2f20fe..0ec5d6e0d17 100644 --- a/src/compiler/spirv/spirv_to_nir.c +++ b/src/compiler/spirv/spirv_to_nir.c @@ -3712,11 +3712,15 @@ vtn_handle_barrier(struct vtn_builder *b, SpvOp opcode, /* GLSLang, prior to commit 8297936dd6eb3, emitted OpControlBarrier with * memory semantics of None for GLSL barrier(). + * And before that, prior to c3f1cdfa, emitted the OpControlBarrier with + * Device instead of Workgroup for execution scope. */ if (b->wa_glslang_cs_barrier && b->nb.shader->info.stage == MESA_SHADER_COMPUTE && - execution_scope == SpvScopeWorkgroup && + (execution_scope == SpvScopeWorkgroup || + execution_scope == SpvScopeDevice) && memory_semantics == SpvMemorySemanticsMaskNone) { + execution_scope = SpvScopeWorkgroup; memory_scope = SpvScopeWorkgroup; memory_semantics = SpvMemorySemanticsAcquireReleaseMask | SpvMemorySemanticsWorkgroupMemoryMask; _______________________________________________ mesa-commit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-commit
