Module: Mesa
Branch: staging/20.2
Commit: 732b28c8b1cd3e7815bacf8e3fe31461e514c397
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=732b28c8b1cd3e7815bacf8e3fe31461e514c397

Author: Jose Maria Casanova Crespo <[email protected]>
Date:   Fri Oct  9 18:40:45 2020 +0200

vc4: Enable lower_umax and lower_umin

VC4 doesn't have support for UMAX and UMIN integer operations. So
we should avoid algebraic optimizations that generate umax/umin ops.

Fixes: 8e1b75b330954a ("nir/algebraic: optimize iand/ior of (n)eq zero")
Reviewed-by: Alejandro PiƱeiro <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7083>
(cherry picked from commit d5e5f72e06165928ee5d9f13d0de7d73038daa0e)

---

 .pick_status.json                     | 2 +-
 src/gallium/drivers/vc4/vc4_program.c | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/.pick_status.json b/.pick_status.json
index 0d642859000..57809707fbd 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -5908,7 +5908,7 @@
         "description": "vc4: Enable lower_umax and lower_umin",
         "nominated": true,
         "nomination_type": 1,
-        "resolution": 0,
+        "resolution": 1,
         "master_sha": null,
         "because_sha": "8e1b75b330954a2e40e8ed0c04871e43120d4f4a"
     },
diff --git a/src/gallium/drivers/vc4/vc4_program.c 
b/src/gallium/drivers/vc4/vc4_program.c
index 9c89ef6843f..d59651b4a31 100644
--- a/src/gallium/drivers/vc4/vc4_program.c
+++ b/src/gallium/drivers/vc4/vc4_program.c
@@ -2190,6 +2190,8 @@ static const nir_shader_compiler_options nir_options = {
         .lower_negate = true,
         .lower_rotate = true,
         .lower_to_scalar = true,
+        .lower_umax = true,
+        .lower_umin = true,
         .max_unroll_iterations = 32,
 };
 

_______________________________________________
mesa-commit mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to