Module: Mesa Branch: master Commit: 5f16c5b6f96640953226f7f9a2da438616a26c69 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=5f16c5b6f96640953226f7f9a2da438616a26c69
Author: Iago Toral Quiroga <[email protected]> Date: Thu Oct 22 10:58:16 2020 +0200 v3dv: properly describe swap_color_rb This key field is only used for V3D versions before 4.1, so it should not be set for v3dv. Also, it is a mask not a boolean. Reviewed-by: Alejandro Piñeiro <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7271> --- src/broadcom/vulkan/v3dv_pipeline.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/broadcom/vulkan/v3dv_pipeline.c b/src/broadcom/vulkan/v3dv_pipeline.c index 379b0eb6ea2..74eb9bf057c 100644 --- a/src/broadcom/vulkan/v3dv_pipeline.c +++ b/src/broadcom/vulkan/v3dv_pipeline.c @@ -1154,10 +1154,10 @@ pipeline_populate_v3d_fs_key(struct v3d_fs_key *key, key->alpha_test = false; key->alpha_test_func = COMPARE_FUNC_NEVER; - /* FIXME: placeholder. Final value for swap_color_rb depends on the format - * of the surface to be used. + /* This is intended for V3D versions before 4.1, otherwise we just use the + * tile buffer load/store swap R/B bit. */ - key->swap_color_rb = false; + key->swap_color_rb = 0; const struct v3dv_render_pass *pass = v3dv_render_pass_from_handle(pCreateInfo->renderPass); _______________________________________________ mesa-commit mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/mesa-commit
