URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=654376faad6c6be108ac938801ff732fd986f6c9
Author: Chad Versace <[email protected]>
Date: Tue Sep 8 09:44:43 2020 -0700
anv/image: Fix isl_surf_usage_flags for stencil images
Respect VkImageStencilUsageCreateInfoEXT.
CC: [email protected]
Reviewed-by: Lionel Landwerlin <[email protected]>
Reviewed-by: Jason Ekstrand <[email protected]>
(cherry picked from commit b50275a4b63d3da12ead2f6e57be8988223af83d)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=c9d10b391c121e0518b9e2b124f87aa28c108970
Author: Chad Versace <[email protected]>
Date: Tue Aug 4 10:14:11 2020 -0700
anv/image: Check DISJOINT in vkGetPhysicalDeviceImageFormatProperties2 (v2)
The code did not return error when VK_IMAGE_CREATE_DISJOINT_BIT was
incompatible with the other input params.
If the Vulkan spec forbids a set of input params for vkCreateImage,
but permits them for vkGetPhysicalDeviceImageFormatProperties2,
then vkGetPhysicalDeviceImageFormatProperties2 must reject those input
params with failure.
- v2: Clearer commit message.
CC: <[email protected]>
Reviewed-by: Lionel Landwerlin <[email protected]> (v2)
Reviewed-by: Jason Ekstrand <[email protected]>
(cherry picked from commit 51a19c83b000407a31b5cd17b996084a6b58a4ff)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=1534e28669ddaec5031027f6f98e3ae371a09a42
Author: Erik Faye-Lund <[email protected]>
Date: Fri Nov 13 16:53:04 2020 +0100
zink: more accurately track supported blits
We don't care if blits need to respect render-conditions if there's no
active one. So let's hit the potentially faster native blit-paths
instead.
Fixes: 5743fa6e709 ("zink: enable conditional rendering if available")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3792
Reviewed-By: Mike Blumenkrantz <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7606>
(cherry picked from commit 19906022e22cb37493861b6976c9623618b5b769)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=f076b4d3ab9b56f9ee2316f6df2898d0a13ce517
Author: Vinson Lee <[email protected]>
Date: Mon Nov 16 16:23:47 2020 -0800
turnip: Close sync_fd only if it is a valid file descriptor.
Fix defects reported by Coverity Scan.
Argument cannot be negative (NEGATIVE_RETURNS)
negative_returns: sync_fd is passed to a parameter that cannot be negative.
Fixes: cec0bc73e55 ("turnip: rework fences to use syncobjs")
Signed-off-by: Vinson Lee <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7647>
(cherry picked from commit 69cad1f96ef4481cc2395def9c993ddcbb0e2540)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=f6a73228a47915e703afcc1e13b8a9b752504c36
Author: Vinson Lee <[email protected]>
Date: Mon Nov 9 17:31:36 2020 -0800
clover/spirv: Add missing break for SpvOpExecutionMode case.
Fix defect reported by Coverity Scan.
Missing break in switch (MISSING_BREAK)
unterminated_case: The case for value SpvOpExecutionMode is not
terminated by a 'break' statement.
Fixes: ee5b46fcfdb ("clover/spirv: support
CL_KERNEL_COMPILE_WORK_GROUP_SIZE")
Signed-off-by: Vinson Lee <[email protected]>
Reviewed-by: Karol Herbst <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7519>
(cherry picked from commit 71ee4e2853bc4af270969e6d91533cba7b9c0cb4)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=5953d04aec1704fd28cb006282685cc8d34ddecc
Author: Vinson Lee <[email protected]>
Date: Wed Oct 28 19:47:42 2020 -0700
frontends/va: Fix *num_entrypoints check.
Fix defect reported by Coverity Scan.
Dereference before null check (REVERSE_INULL)
check_after_deref: Null-checking num_entrypoints suggests that it
may be null, but it has already been dereferenced on all paths
leading to the check.
Fixes: 5bcaa1b9e970 ("st/va: add encode entrypoint v2")
Signed-off-by: Vinson Lee <[email protected]>
Reviewed-by: Pierre-Eric Pelloux-Prayer <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7360>
(cherry picked from commit 7820c8c13ff3e9367b208f09059c940a1629f708)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=94f202c6bc5371ccdc21b96dc5a2afb076fd64a6
Author: Eric Anholt <[email protected]>
Date: Mon Aug 3 19:23:34 2020 -0700
freedreno: Fix leak of shader binary on disk cache hits.
It's supposed to be ralloced -- there's not even a shader variant destroy
function for freeing, just ralloc_free() on the ir3_shader_variant or the
parent ir3_shader when you're done!
Fixes: f97acb4bb4b1 ("freedreno/ir3: disk-cache support")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5810>
(cherry picked from commit 433841d9eb7cd9dd5e00b2f47cd998e0e986ef02)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=d7366262d2b4e341c09a1b7b15e2c1d72424c03e
Author: Lucas Stach <[email protected]>
Date: Mon Nov 16 14:58:38 2020 +0100
etnaviv: fix disabling of INT filter for real
Missing a copy of the pipe_sampler_state into the etna_sampler_state object
lead to the texture_use_int_filter() to always see a max_anisotropy of 0, so
the INT filter wasn't disabled when necessary. Also state emission should
never change the state objects, as this might also lead to stale information
being kept around the in the state object.
Fixes: 89a41dae7702 (etnaviv: do not use int filter when
anisotropic filtering is used)
Cc: <[email protected]>
Signed-off-by: Lucas Stach <[email protected]>
Reviewed-by: Christian Gmeiner <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7638>
(cherry picked from commit b479a1f03cdcf70b86df6903ace6ff8c92f205b9)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=ce29a107f438247aab2df9f38af74286408c1630
Author: Erik Faye-Lund <[email protected]>
Date: Mon Nov 16 12:33:36 2020 +0100
mesa/main: add missing include in glformats.h
This header uses uint32_t without including stdint.h. This worked fine
by accident until a new c-source started including it.
Fixes: 1bf539b3a21 ("mesa: Clamp some depth values in glClearBufferfv")
Reviewed-by: Tapani Pälli <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7637>
(cherry picked from commit 2410def98fa688aa009b42de3224e12e5ddbaff3)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=9d399939e0842b756652c825d211ce1349029492
Author: Rhys Perry <[email protected]>
Date: Fri Nov 13 15:12:21 2020 +0000
aco: fix fp16 *0.5 omod
We were testing for -0.5 instead.
Signed-off-by: Rhys Perry <[email protected]>
Reviewed-by: Samuel Pitoiset <[email protected]>
Fixes: 1210e0bd620 ("aco: create 16-bit input and output modifiers")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7605>
(cherry picked from commit 0c522d3aa7432b72c2ed773218d6f0eb25f58943)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=dc0580d3441152336134d4840a7b70389bd67cd5
Author: Rhys Perry <[email protected]>
Date: Fri Nov 13 15:10:58 2020 +0000
aco: disable omod if the sign of zeros should be preserved
The RDNA ISA doc says that omod doesn't preserve -0.0 in 6.2.2. LLVM
appears to always disable omod in this situation, but clamp is unaffected.
Signed-off-by: Rhys Perry <[email protected]>
Reviewed-by: Samuel Pitoiset <[email protected]>
Fixes: df645fa369d ("aco: implement VK_KHR_shader_float_controls")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7605>
(cherry picked from commit 558daa73f9adb1275ddcf00515c7f79f726b7ae1)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=ded5cd528a9567fce68909a60c19dbd6b65c1211
Author: Tapani Pälli <[email protected]>
Date: Wed Nov 11 08:59:46 2020 +0200
iris: initialize shared screen->vtbl only once
Screen is shared among contexts, other context might be already using
vtbl while another initializes it again.
==45872== Possible data race during write of size 8 at 0x5DDAE78 by thread
#549
==45872== Locks held: 1, at address 0x5D1B6F8
==45872== at 0x6D66D91: gen9_init_state (iris_state.c:7816)
==45872== by 0x6BA0A31: iris_create_context (iris_context.c:342)
==45872== by 0x621F390: st_api_create_context (st_manager.c:917)
==45872== by 0x620E6F9: dri_create_context (dri_context.c:163)
==45872== by 0x6A40DB1: driCreateContextAttribs (dri_util.c:480)
==45872== by 0x540B963: dri2_create_context (egl_dri2.c:1583)
==45872== by 0x53FB84E: eglCreateContext (eglapi.c:821)
==45872==
==45872== This conflicts with a previous read of size 8 by thread #544
==45872== Locks held: 1, at address 0x5F6E0E0
==45872== at 0x6CB779E: blorp_alloc_binding_table (iris_blorp.c:167)
==45872== by 0x6CAEF70: blorp_emit_surface_states
(blorp_genX_exec.h:1540)
==45872== by 0x6CB67F9: blorp_exec (blorp_genX_exec.h:2016)
==45872== by 0x6CB7AFE: iris_blorp_exec (iris_blorp.c:307)
==45872== by 0x70F5916: try_blorp_blit (blorp_blit.c:2145)
==45872== by 0x70F5FCA: do_blorp_blit (blorp_blit.c:2273)
==45872== by 0x70F778F: blorp_copy (blorp_blit.c:2803)
==45872== by 0x6BB9EB6: iris_copy_region (iris_blit.c:725)
v2: move as genX(init_screen_state) (Lionel)
Signed-off-by: Tapani Pälli <[email protected]>
Reviewed-by: Lionel Landwerlin <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7544>
(cherry picked from commit 460287adcadf1c03b13fccd397fcd9d270c4d31d)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=15367d29693891a809ddae5baee686b16b0bfa3e
Author: Tapani Pälli <[email protected]>
Date: Tue Nov 10 15:52:00 2020 +0200
egl/dri2: fix race between image create and egl_image_target_texture
All other functions calling _eglLookupImage hold the display lock.
==16659== Possible data race during write of size 8 at 0x5D1BCF0 by thread
#2668
==16659== Locks held: 1, at address 0x5D1B6F8
==16659== at 0x5405DDF: _eglLinkResource (egldisplay.c:454)
==16659== by 0x53F9189: _eglLinkImage (eglimage.h:138)
==16659== by 0x53FE2CA: _eglCreateImageCommon (eglapi.c:1740)
==16659== by 0x53FE39A: eglCreateImageKHR (eglapi.c:1751)
==16659==
==16659== This conflicts with a previous read of size 8 by thread #2664
==16659== Locks held: 1, at address 0x5308D00
==16659== at 0x5405C06: _eglCheckResource (egldisplay.c:387)
==16659== by 0x5408C92: _eglLookupImage (eglimage.h:162)
==16659== by 0x5409E96: dri2_lookup_egl_image (egl_dri2.c:688)
==16659== by 0x6210AAF: dri2_lookup_egl_image (dri_helpers.c:250)
==16659== by 0x6212843: dri_get_egl_image (dri_screen.c:470)
==16659== by 0x625F7CC: st_get_egl_image (st_cb_eglimage.c:152)
==16659== by 0x625FE7D: st_egl_image_target_texture_2d
(st_cb_eglimage.c:354)
==16659== by 0x6501C05: egl_image_target_texture (teximage.c:3446)
Signed-off-by: Tapani Pälli <[email protected]>
Reviewed-by: Lionel Landwerlin <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7544>
(cherry picked from commit 959c2d1edbf56934f6d313a48136f6f1740dc549)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=ee3ed20f3d89332a541a9fc4b3c09cbd010e82cf
Author: Dave Airlie <[email protected]>
Date: Fri Nov 13 17:15:53 2020 +1000
draw: fix tess eval pipeline statistics.
The number of invocations wasn't getting incremented correctly.
Fixes: 202bc38ce9e3 ("draw: collect tessellation invocations statistics")
Reviewed-by: Roland Scheidegger <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7597>
(cherry picked from commit ce07c52b825903e698b63bc608d7ddb8cb578cd6)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=e5327be5acbb0fd115505a05e43b4cb0822ceace
Author: Christian Gmeiner <[email protected]>
Date: Sun Nov 15 11:56:23 2020 +0100
etnaviv: nir: do not run opt loop after nir_lower_bool_xxx(..)
Running the optimizations after bool to float/int lowering is not going
to work. Large portions of NIR are likely to blow up if they see
floats/ints in weird places. Most of the bool->float/int conversions
are direct instruction substitutions and it's not going to leave a lot
of garbage around to optimize.
Fixes nir.h:261: nir_const_value_as_bool: Assertion `i == 0 || i == -1'
failed
dEQP-GLES2.functional.shaders.loops.while_constant_iterations.no_iterations_vertex
Here are shader-db results for GC2000:
instructions HURT: shaders/tesseract/488.shader_test FRAG: 516
-> 524 (1.55%)
instructions HURT: shaders/tesseract/491.shader_test FRAG: 248
-> 260 (4.84%)
instructions HURT: shaders/tesseract/494.shader_test FRAG: 244
-> 256 (4.92%)
instructions HURT: shaders/tesseract/238.shader_test FRAG: 232
-> 244 (5.17%)
instructions HURT: shaders/tesseract/241.shader_test FRAG: 232
-> 244 (5.17%)
instructions HURT: shaders/tesseract/127.shader_test FRAG: 76
-> 80 (5.26%)
instructions HURT: shaders/tesseract/130.shader_test FRAG: 148
-> 156 (5.41%)
instructions HURT: shaders/tesseract/226.shader_test FRAG: 192
-> 204 (6.25%)
instructions HURT: shaders/tesseract/229.shader_test FRAG: 192
-> 204 (6.25%)
instructions HURT: shaders/tesseract/217.shader_test FRAG: 152
-> 164 (7.89%)
instructions HURT: shaders/tesseract/214.shader_test FRAG: 152
-> 164 (7.89%)
instructions HURT: shaders/tesseract/205.shader_test FRAG: 112
-> 124 (10.71%)
instructions HURT: shaders/tesseract/202.shader_test FRAG: 112
-> 124 (10.71%)
instructions HURT: shaders/tesseract/169.shader_test FRAG: 32
-> 36 (12.50%)
instructions HURT: shaders/tesseract/166.shader_test FRAG: 32
-> 36 (12.50%)
instructions HURT: shaders/deqp_gles3/61312.shader_test FRAG: 448
-> 508 (13.39%)
instructions HURT: shaders/deqp_gles3/61309.shader_test FRAG: 448
-> 508 (13.39%)
instructions HURT: shaders/deqp_gles3/61324.shader_test FRAG: 448
-> 508 (13.39%)
instructions HURT: shaders/tesseract/118.shader_test FRAG: 28
-> 32 (14.29%)
instructions HURT: shaders/tesseract/181.shader_test FRAG: 52
-> 60 (15.38%)
instructions HURT: shaders/tesseract/178.shader_test FRAG: 52
-> 60 (15.38%)
instructions HURT: shaders/tesseract/121.shader_test FRAG: 52
-> 60 (15.38%)
instructions HURT: shaders/tesseract/193.shader_test FRAG: 72
-> 84 (16.67%)
instructions HURT: shaders/tesseract/190.shader_test FRAG: 72
-> 84 (16.67%)
total instructions in shared programs: 64220 -> 64572 (0.55%)
instructions in affected programs: 4924 -> 5276 (7.15%)
helped: 5
HURT: 24
helped stats (abs) min: 4 max: 8 x̄: 5.60 x̃: 4
helped stats (rel) min: 4.35% max: 5.41% x̄: 4.72% x̃: 4.35%
HURT stats (abs) min: 4 max: 60 x̄: 15.83 x̃: 12
HURT stats (rel) min: 1.55% max: 16.67% x̄: 10.04% x̃: 10.71%
95% mean confidence interval for instructions value: 5.39 18.89
95% mean confidence interval for instructions %-change: 4.81% 10.18%
Instructions are HURT.
total temps in shared programs: 2514 -> 2512 (-0.08%)
temps in affected programs: 9 -> 7 (-22.22%)
helped: 2
HURT: 0
Cc: <[email protected]>
Signed-off-by: Christian Gmeiner <[email protected]>
Reviewed-by: Lucas Stach <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7624>
(cherry picked from commit 9b6516ac249ee479b78e399e1a54a293e53e9676)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=b8ddfc0bb78b8e295a2278a0b7196acce287391b
Author: Vinson Lee <[email protected]>
Date: Fri Oct 16 15:41:12 2020 -0700
vdpau: Add missing printf format specifier.
Fix defect reported by Coverity Scan.
Extra argument to printf format specifier (PRINTF_ARGS)
extra_argument: This argument was not used by the format string:
vmixer->max_layers.
Fixes: 89b986325227 ("vdpau: Add support for parameters")
Signed-off-by: Vinson Lee <[email protected]>
Reviewed-by: Leo Liu <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7200>
(cherry picked from commit 3fe5c13d71b831b42798755a3ba983b5de6d1563)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=159ded94814ee78496e87897d1f774e317c20613
Author: Rob Clark <[email protected]>
Date: Thu Nov 12 12:39:28 2020 -0800
freedreno/ir3: Fix crash in shader compile fail path
Fixes: 74140c2e859 ("freedreno/ir3: convert over to ralloc")
Signed-off-by: Rob Clark <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7612>
(cherry picked from commit 4b65c09d86d37efa34e93b17b0e4a03546f26af9)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=4de41dea583c14dd306749a74942685183fe60d9
Author: Icecream95 <[email protected]>
Date: Sat Nov 14 00:12:26 2020 +1300
panfrost: Fix stack shift calculation
Fixes flickering in Neverwinter Nights.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/3789
Fixes: e6152091ca9 ("panfrost: Use canonical characterization of tls_size")
Reviewed-by: Alyssa Rosenzweig <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7613>
(cherry picked from commit 12dec2004ed0b50b0cb0ad7cc635f2a706be9891)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=b37d613da5b0393f1a2ba34dd5baea9916dd0b9b
Author: Nanley Chery <[email protected]>
Date: Fri Nov 6 10:55:03 2020 -0800
mesa: Clamp some depth values in glClearBufferfi
OpenGL 3.0 spec, section 4.2.3 "Clearing the Buffers":
depth and stencil are the values to clear the depth and stencil
buffers to, respectively. Clamping and type conversion for
fixed-point depth buffers are performed in the same fashion as for
ClearDepth.
Enables iris to pass the clearbuffer-depth-stencil piglit test.
Cc: mesa-stable
Reviewed-by: Eric Anholt <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7410>
(cherry picked from commit 2e713313a29422b38435c91f8277c1893fcad095)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=d47cb4124ac9d515bd91fa3c1e807ac1c05bda35
Author: Nanley Chery <[email protected]>
Date: Mon Nov 2 09:02:42 2020 -0800
mesa: Clamp some depth values in glClearBufferfv
OpenGL 3.0 spec, section 4.2.3 "Clearing the Buffers":
If buffer is DEPTH, drawbuffer must be zero, and value points to the
single depth value to clear the depth buffer to. Clamping and type
conversion for fixed-point depth buffers are performed in the same
fashion as for ClearDepth.
Enables iris to pass the clearbuffer-depth piglit test.
v2. Add spec citation. (Eric Anholt)
v3. Don't clamp floating point formats. (Eric Anholt)
Cc: mesa-stable
Reviewed-by: Marek Olšák <[email protected]>
Reviewed-by: Eric Anholt <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7410>
(cherry picked from commit 1bf539b3a2129779addde397886870c00045e6d7)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=5b83eb0b0980a5f488ef4bab589f8537960f7072
Author: Nanley Chery <[email protected]>
Date: Thu Nov 5 15:45:44 2020 -0800
mesa: Add and use _mesa_has_depth_float_channel
Reviewed-by: Marek Olšák <[email protected]>
Reviewed-by: Eric Anholt <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7410>
(cherry picked from commit fda015023af5d0d2d844d5fde07a8c19e4d8f453)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=14167715ccc8619fcc75dce0ad4681aebeab9cd6
Author: Dylan Baker <[email protected]>
Date: Tue Nov 17 10:55:38 2020 -0800
.pick_status.json: Update to 87dc3106b077199b829a082e32ec33d0c6d400ab
_______________________________________________
mesa-commit mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-commit
