Module: Mesa
Branch: staging/20.3
Commit: 10a9d8a10f48525d8dc40e1ae297228f787c6475
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=10a9d8a10f48525d8dc40e1ae297228f787c6475

Author: Dave Airlie <[email protected]>
Date:   Tue Nov 10 14:26:53 2020 +1000

lavapipe: fixup mipmap precsion bits

8 seems more correct, however it fixes a bunch of explict lod
tests but breaks some lod query tests.

Cc: "20.3" <[email protected]>
Reviewed-by: Adam Jackson <[email protected]>
Reviewed-by: Roland Scheidegger <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7705>
(cherry picked from commit 4263162839d67f08c69895925ffc19cb4fbf4c42)

---

 .pick_status.json                           | 2 +-
 src/gallium/frontends/lavapipe/lvp_device.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/.pick_status.json b/.pick_status.json
index c65afbc0538..61c1c964767 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -598,7 +598,7 @@
         "description": "lavapipe: fixup mipmap precsion bits",
         "nominated": true,
         "nomination_type": 0,
-        "resolution": 0,
+        "resolution": 1,
         "master_sha": null,
         "because_sha": null
     },
diff --git a/src/gallium/frontends/lavapipe/lvp_device.c 
b/src/gallium/frontends/lavapipe/lvp_device.c
index 0c1a65abbdd..893c8a6af67 100644
--- a/src/gallium/frontends/lavapipe/lvp_device.c
+++ b/src/gallium/frontends/lavapipe/lvp_device.c
@@ -463,8 +463,8 @@ void lvp_GetPhysicalDeviceProperties(VkPhysicalDevice 
physicalDevice,
       .maxComputeWorkGroupInvocations           = max_threads_per_block,
       .maxComputeWorkGroupSize = { block_size[0], block_size[1], block_size[2] 
},
       .subPixelPrecisionBits                    = 
pdevice->pscreen->get_param(pdevice->pscreen, 
PIPE_CAP_RASTERIZER_SUBPIXEL_BITS),
-      .subTexelPrecisionBits                    = 4 /* FIXME */,
-      .mipmapPrecisionBits                      = 4 /* FIXME */,
+      .subTexelPrecisionBits                    = 8,
+      .mipmapPrecisionBits                      = 8,
       .maxDrawIndexedIndexValue                 = UINT32_MAX,
       .maxDrawIndirectCount                     = UINT32_MAX,
       .maxSamplerLodBias                        = 16,

_______________________________________________
mesa-commit mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/mesa-commit

Reply via email to