Module: Mesa Branch: main Commit: e9afd245f4b158b7e9c1d1ac4d52be65600b7737 URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e9afd245f4b158b7e9c1d1ac4d52be65600b7737
Author: Alyssa Rosenzweig <[email protected]> Date: Tue Aug 24 14:41:14 2021 -0400 panfrost: Remove stale TODOs and XXXs These don't meaningfully apply but their comments never got updated. Signed-off-by: Alyssa Rosenzweig <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12530> --- src/gallium/drivers/panfrost/pan_cmdstream.c | 1 - src/gallium/drivers/panfrost/pan_context.h | 3 --- src/gallium/drivers/panfrost/pan_job.c | 4 +++- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_cmdstream.c b/src/gallium/drivers/panfrost/pan_cmdstream.c index affc681fe36..b444a2d88b8 100644 --- a/src/gallium/drivers/panfrost/pan_cmdstream.c +++ b/src/gallium/drivers/panfrost/pan_cmdstream.c @@ -1422,7 +1422,6 @@ emit_image_bufs(struct panfrost_batch *batch, enum pipe_shader_type shader, for (unsigned i = 0; i < last_bit; ++i) { struct pipe_image_view *image = &ctx->images[shader][i]; - /* TODO: understand how v3d/freedreno does it */ if (!(ctx->image_mask[shader] & (1 << i)) || !(image->shader_access & PIPE_IMAGE_ACCESS_READ_WRITE)) { /* Unused image bindings */ diff --git a/src/gallium/drivers/panfrost/pan_context.h b/src/gallium/drivers/panfrost/pan_context.h index 02c44cb794c..b8debbaeeae 100644 --- a/src/gallium/drivers/panfrost/pan_context.h +++ b/src/gallium/drivers/panfrost/pan_context.h @@ -178,10 +178,7 @@ struct panfrost_context { * it is disabled, just equal to plain vertex count */ unsigned padded_count; - /* TODO: Multiple uniform buffers (index =/= 0), finer updates? */ - struct panfrost_constant_buffer constant_buffer[PIPE_SHADER_TYPES]; - struct panfrost_rasterizer *rasterizer; struct panfrost_shader_variants *shader[PIPE_SHADER_TYPES]; struct panfrost_vertex_state *vertex; diff --git a/src/gallium/drivers/panfrost/pan_job.c b/src/gallium/drivers/panfrost/pan_job.c index 72e2f0c9348..649809a2903 100644 --- a/src/gallium/drivers/panfrost/pan_job.c +++ b/src/gallium/drivers/panfrost/pan_job.c @@ -410,7 +410,9 @@ panfrost_batch_get_polygon_list(struct panfrost_batch *batch) uint32_t *polygon_list_body = batch->tiler_ctx.midgard.polygon_list->ptr.cpu + MALI_MIDGARD_TILER_MINIMUM_HEADER_SIZE; - polygon_list_body[0] = 0xa0000000; /* TODO: Just that? */ + + /* Magic for Mali T720 */ + polygon_list_body[0] = 0xa0000000; } batch->tiler_ctx.midgard.disable = !has_draws;
