URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=15c8aeef1d595ffd6bccf92d282cb524e4617dd3
Author: Dylan Baker <[email protected]>
Date: Tue Sep 21 09:52:44 2021 -0700
VERSION: bump for 21.2.2 release
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=32cf8bc08159e5bd0a0dd768ecffb9043156e2a5
Author: Dylan Baker <[email protected]>
Date: Tue Sep 21 09:52:15 2021 -0700
docs: add release notes for 21.2.2
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=a46d95bd7064f47e8649abc8219a237085849b33
Author: Mike Blumenkrantz <[email protected]>
Date: Mon Sep 13 07:49:54 2021 -0400
zink: fix ZINK_MAX_DESCRIPTORS_PER_TYPE to stop exploding the stack
this isn't the max per type, it's the max that can be used for a type,
which is the max used by a shader stage * the number of shader stages
Cc: mesa-stable
Reviewed-by: Erik Faye-Lund <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12829>
(cherry picked from commit a45c84f2266a0e117b867bbab694f25352c603d2)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=ddb5243ccd3e33a9b7aaf5d88c97ad32fe437572
Author: Juan A. Suarez Romero <[email protected]>
Date: Wed Sep 8 10:04:45 2021 +0200
broadcom/compiler: force a last thrsw for spilling
As we don't know if we are going to have spilling or not, emit always a
last thrsw at the end of the shader.
If later we don't have spillings and we don't need that last thrsw, we
remove it and switch back to the previous one.
This way we ensure all the spilling happens always before the last
thrsw.
v2 (Juan):
- Rework the code to force a last thrsw and remove later if no spilling
v3:
- Merge functionality inside vir_emit_last_thrsw (Iago)
- Add vir_restore_last_thrsw (Juan)
v4 (Iago):
- Fix/add new comments
- Rename variables/parameters
v5 (Iago):
- Fix comments
- Add assertion
Cc: mesa-stable
Fixes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4760
Reviewed-by: Iago Toral Quiroga <[email protected]>
Signed-off-by: Juan A. Suarez Romero <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12322>
(cherry picked from commit c98ddc778a34683e55d29122edba53ac4969deea)
Conflicts:
src/broadcom/compiler/nir_to_vir.c
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=bf7543fcefa04c5aed29583a496de1355bf0e233
Author: Samuel Pitoiset <[email protected]>
Date: Mon Sep 13 15:41:39 2021 +0200
radv/llvm: fix using Wave32
The Wave32 pass manager has been removed a while ago.
Fixes: 94a1f45e15a ("ac/llvm: set target features per function instead of
per target machine")
Signed-off-by: Samuel Pitoiset <[email protected]>
Reviewed-by: Bas Nieuwenhuizen <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12833>
(cherry picked from commit 5eda8e5fe9038bf5ebf2bc203e62e4a2c54e609d)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=910e3faa5cf747a27eb24aa4b176606e6c881886
Author: Ian Romanick <[email protected]>
Date: Thu Sep 9 16:54:11 2021 -0700
nir/lower_gs_intrinsics: Return progress if
append_set_vertex_and_primitive_count makes progress
Reviewed-by: Timur Kristóf <[email protected]>
Fixes: 542d40d698a ("nir: Add new GS intrinsics that maintain a count of
emitted vertices.")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12802>
(cherry picked from commit edf357b2330dfcefae1a26fb0761fd53c75b77f5)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=6222be278c4c2ab65b5a0df209e097cfdb4aafec
Author: Dave Airlie <[email protected]>
Date: Tue Sep 14 16:59:03 2021 +1000
crocus/gen7: add missing IVB/GT2 geom shader workaround.
Noticed this in passing.
Fixes: f3630548f1da ("crocus: initial gallium driver for Intel gfx 4-7")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12847>
(cherry picked from commit 4149a60209ddd91f52e35318d58831e3196dd67f)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=11195ad7fe469cfb76f43551d54713edd79ff376
Author: Jordan Justen <[email protected]>
Date: Thu May 16 16:24:18 2019 -0700
intel/isl: Enable MOCS 61 for external surfaces on TGL
Reworks:
* Lionel/Francisco: Add comment
Cc: mesa-stable
Signed-off-by: Jordan Justen <[email protected]>
Acked-by: Lionel Landwerlin <[email protected]>
Reviewed-by: Francisco Jerez <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12292>
(cherry picked from commit 333b2185d8da35d1dc6bc07e17bed5395890a2ff)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=87edf61fc7968cc0c42a7ed9e922cfe0a15c0d2d
Author: Marek Olšák <[email protected]>
Date: Wed Aug 18 11:12:30 2021 -0400
radeonsi: strengthen the VGT_FLUSH condition in begin_new_gfx_cs
Cc: mesa-stable
Acked-by: Pierre-Eric Pelloux-Prayer <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12812>
(cherry picked from commit a2a7610e1fd27e789cab13ce54ee3233791c26f0)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=656659a4cc84374abb570b3a49ea42debfef80bd
Author: Bas Nieuwenhuizen <[email protected]>
Date: Sat Sep 4 14:27:58 2021 +0200
nir: Avoid visiting instructions multiple times in nir_instr_free_and_dce.
Sadly need to poke a bit in the src internals to avoid using yet another
heap allocated datastructure.
Fixes: 52515485723 ("nir: Add a nir_instr_remove that recursively removes
dead code.")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5323
Reviewed-by: Emma Anholt <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12726>
(cherry picked from commit b05cd10b8e49a04f3382112ee568b61853fbda0e)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=4a94de804d1d4a6650deadc1dfc84501ed9252d4
Author: Dylan Baker <[email protected]>
Date: Wed Sep 15 09:19:26 2021 -0700
.pick_status.json: Update to 7244aa19806cec5265e1e219cac1a99b0d3c62c6
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=289eb46bdda98b00db1baae315fa6b133b6003fb
Author: Rhys Perry <[email protected]>
Date: Wed Sep 8 18:09:18 2021 +0100
nir: fix serialization of loop/if control
Signed-off-by: Rhys Perry <[email protected]>
Reviewed-by: Caio Marcelo de Oliveira Filho <[email protected]>
Fixes: e76ae39ae22 ("nir: add support for user defined select control")
Fixes: b56451f82c1 ("nir: add support for user defined loop control")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12778>
(cherry picked from commit c1f724b2b93cf28f72b7695edfabc1d2557faa48)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=38d30c07b8b383e49efd64ce114d9fc16850739e
Author: Dylan Baker <[email protected]>
Date: Thu Sep 9 09:14:12 2021 -0700
.pick_status.json: Update to b58d6eaf1174aab296c4230e3895c65cba4bd9e3
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=02252789d8b0d15c78c2170e71617a0eef565579
Author: Timur Kristóf <[email protected]>
Date: Wed Sep 1 18:09:01 2021 +0200
aco: Skip code paths to emit copies when there are no copies.
Found while running with libstdc++ debug mode.
Fixes the following:
Error: attempt to advance a dereferenceable (start-of-sequence)
iterator -1 steps, which falls outside its valid range.
Cc: mesa-stable
Signed-off-by: Timur Kristóf <[email protected]>
Reviewed-by: Rhys Perry <[email protected]>
Reviewed-by: Tony Wasserka <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12682>
(cherry picked from commit bb956464cbc3d5012527ea3d16dbd3f2c96cdae1)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=a85cdda14b80a04db50e98efc7e3ad3eb8738fac
Author: Timur Kristóf <[email protected]>
Date: Wed Sep 1 17:16:16 2021 +0200
aco: Use Builder reference in emit_copies_block.
Found while running with libstdc++ debug mode.
Fixes the following:
Error: attempt to copy-construct an iterator from a singular iterator.
Cc: mesa-stable
Signed-off-by: Timur Kristóf <[email protected]>
Reviewed-by: Rhys Perry <[email protected]>
Reviewed-by: Tony Wasserka <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12682>
(cherry picked from commit 728ed892df118d00c20c3317803c3279f84d9676)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=0ff85a144b779263803e7ce4ce510c70b5ceb9dc
Author: Rhys Perry <[email protected]>
Date: Thu Sep 2 17:30:57 2021 +0100
aco/spill: add temporary operands of exec phis to next_use_distances_end
Signed-off-by: Rhys Perry <[email protected]>
Reviewed-by: Daniel Schürmann <[email protected]>
Fixes: dfb10e4f4b7 ("aco/spill: don't count phis as variable access")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12702>
(cherry picked from commit 54f83d718ad6d089bfd0a018db8c9a0bbdc5c9ea)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=a31df83f962d782dd6be30bd1d7a145d3f9e32a2
Author: Daniel Schürmann <[email protected]>
Date: Wed Sep 1 15:22:12 2021 +0200
aco: fix p_insert lowering with 16bit sources
The previous lowering only wrote a single byte.
Fixes: 2f94353735b5ddfe2a72499e7bf6c7bbc80b9a00 ('aco: add
p_extract/p_insert')
Reviewed-by: Rhys Perry <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12640>
(cherry picked from commit cc4682ed471d8fc0e10f3480183310901aa165a6)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=8b677626ef86fced5177859d5771e8b9b5be9ec0
Author: Samuel Pitoiset <[email protected]>
Date: Thu Sep 2 13:37:11 2021 +0200
radv: fix determining the maximum number of waves that can use scratch
This estimation was incorrect, the number of waves doesn't only
depend of the number of VGPRs.
Though, {SPI,COMPUTE}_TMPRING_SIZE.WAVES should limit the number of
scratch waves in flight, not sure if limiting it really works.
This fixes a GPU hang with an upcoming game, and this might also
helps resolving some spurious random GPU hangs.
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <[email protected]>
Reviewed-by: Bas Nieuwenhuizen <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12700>
(cherry picked from commit b31994cf67bc1a4f179fae394d3976a5f73ad877)
Conflicts:
src/amd/vulkan/radv_shader.c
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=7e5083961dcda8e6c4be6004cd39698211b73026
Author: Timur Kristóf <[email protected]>
Date: Wed Sep 1 08:40:45 2021 +0200
aco: Fix invalid usage of std::fill with std::array.
In this case std::array doesn't behave like a regular array, therefore
it is NOT okay to index it outside the array, even though std::fill
needs us to do so.
Change the syntax to do the same thing slightly differently,
and add an assertion to make sure the registers are always within
the array's bounds.
Closes: #5289
Fixes: 0e4747d3fb7ec15f8c1d6b971b1352249e7d95c6
Signed-off-by: Timur Kristóf <[email protected]>
Reviewed-by: Tony Wasserka <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12664>
(cherry picked from commit 9d20cf27326a2ed948182de75dc2c865ff0e7544)
Conflicts:
src/amd/compiler/aco_optimizer_postRA.cpp
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=d3701f91bbb6c03e8d8bd659d3e7d4b82a0dda6b
Author: Corentin Noël <[email protected]>
Date: Tue Sep 7 17:53:41 2021 +0200
glx: Prevent crashes when an extension isn't found
Avoid a NULL-pointer dereference.
Fixes: 2c8a85b712e ("glx: Stash a copy of the XExtCodes in the glx_display")
Signed-off-by: Corentin Noël <[email protected]>
Reviewed-by: Adam Jackson <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12751>
(cherry picked from commit d326d32e24cbcda97c429d935fb869abf972a977)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=d3f8c5ff902c6672a7294c08aa6205d0ec7cd20b
Author: Marcin Ślusarz <[email protected]>
Date: Mon Sep 6 13:02:41 2021 +0200
glsl: break out early if compound assignment's operand errored out
Fixes compiler crashes on:
struct Foo
{
float does_exist_member;
};
in vec2 tex;
out vec4 color;
void
main(void)
{
Foo foo;
foo.does_not_exist_member %= 3; /* or any of: <<=, >>=, &=, |=, ^= */
color = vec4(tex.xy, tex.xy);
}
Signed-off-by: Marcin Ślusarz <[email protected]>
CC: mesa-stable
Reviewed-by: Matt Turner <[email protected]>
Reviewed-by: Tapani Pälli <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12717>
(cherry picked from commit 30b2cc423c5f710033525b94484d6efb45dcf68a)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=5facfec84555a9278597d2f68efedb0e8c280454
Author: Marcin Ślusarz <[email protected]>
Date: Fri Sep 3 11:46:46 2021 +0200
glsl: propagate errors from *=, /=, +=, -= operators
Fixes compiler crash on:
void main()
{
gl_FragColor = a += 1;
}
(a is not declared anywhere)
Found with AFL++.
Fixes: d1fa69ed61d ("glsl: do not attempt assignment if operand type not
parsed correctly")
Signed-off-by: Marcin Ślusarz <[email protected]>
Reviewed-by: Matt Turner <[email protected]>
Reviewed-by: Tapani Pälli <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12717>
(cherry picked from commit 26302ccdc14f10265267f98aa79481ad88cd860c)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=a290407077a61c241841d11c6fe1c06b06142219
Author: Timothy Arceri <[email protected]>
Date: Mon Aug 23 18:54:16 2021 +1000
glsl: fix variable scope for do-while loops
Without this the following code was successfully compiling.
void main()
{
do
int var_1 = 0;
while (false);
var_1++;
}
Fixes: a87ac255cf7e ("Initial commit. lol")
Reviewed-by: Ian Romanick <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12465>
(cherry picked from commit 52893327fb0cc085df6b7b38de0cf240d5f9ae5e)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=d830feb8277d0a73533bcdb38f2dbb5155e5e88b
Author: Timothy Arceri <[email protected]>
Date: Tue Aug 24 17:54:06 2021 +1000
glsl: handle scope correctly when inlining loop expression
We need to clone the previously evaluated loop expression when
inlining otherwise we will have conflicts with shadow variables
defined in deeper scopes.
Fixes: 5c02e2e2de75 ("glsl: Generate IR for switch statements")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5255
Reviewed-by: Ian Romanick <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12465>
(cherry picked from commit 174c057926fddd637d3c038c3162559a38bebe88)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=73d24f9fa84a1ec3038d4d33c24a1259f51e7646
Author: Timothy Arceri <[email protected]>
Date: Mon Aug 23 17:52:22 2021 +1000
glsl: fix variable scope for loop-expression
We need to evaluate the loop-expression of a for loop before
we evaluate the loop body otherwise we will find the wrong
variable for the following loop.
int var_0 = 0;
for(; var_0 < 10; var_0++) {
const float var_0 = 1.0;
gl_FragColor = vec4(0.0, var_0, 0.0, 0.0);
}
Fixes: a87ac255cf7e ("Initial commit. lol")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5262
Reviewed-by: Ian Romanick <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12465>
(cherry picked from commit 8bbbbb02cd5e8b56c8a96c1e5bc52d1df80f6884)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=645ad452a69ec44eaa382b382c3bd4d7005cf5f9
Author: Timothy Arceri <[email protected]>
Date: Tue Sep 7 16:19:17 2021 +1000
mesa: fix mesa_problem() call in _mesa_program_state_flags()
Previously STATE_INTERNAL returned 0 for the unhandled states
but the outer switch throws the error for unhandled states.
Fixes: b4f3497786ef ("mesa: remove STATE_INTERNAL")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5316
Reviewed-by: Marek Olšák <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12746>
(cherry picked from commit 732cd9db445d276de9ce0844430ebc0e9e4ade25)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=c3da924b8658791d92837197840ca18d4b8481d4
Author: Mike Blumenkrantz <[email protected]>
Date: Mon Aug 30 16:22:08 2021 -0400
util/primconvert: force restart rewrites if original primtype wasn't
supported
if we're doing a primtype change, the restart needs to be eliminated to
avoid losing restart data after the rewrite
Fixes: 583070748cb ("util/primconvert: handle rewriting of prim-restart
draws with unsupported primtype")
Acked-by: Rob Clark <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12625>
(cherry picked from commit 5bb747abd9ca8551283f0eee311b9fb1b19fba0d)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=998766f6cc2970fcbd5287e55e17352eebbd85e5
Author: Emma Anholt <[email protected]>
Date: Fri Sep 3 13:28:58 2021 -0700
llvmpipe: Fix leak of CS local memory with 0 threads.
Fixes: bde08ce4d7bf ("llvmpipe: handle compute shader launch with 0
threads")
Reviewed-by: Dave Airlie <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12724>
(cherry picked from commit a83a2b980cd54468247db6540b69975567d09797)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=cd6ef859f0ad3236fce3ef5b7f7ee40a101e1697
Author: Emma Anholt <[email protected]>
Date: Fri Sep 3 16:02:46 2021 -0700
llvmpipe: Free CS shader images on context destroy.
Cc: mesa-stable
Reviewed-by: Dave Airlie <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12724>
(cherry picked from commit dee8b50cad57eb570194257a5b35744c5d79dd73)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=7ed05f3216acd0be081b21390fd9720afd6fcb28
Author: Connor Abbott <[email protected]>
Date: Tue Sep 7 11:45:07 2021 +0200
ir3/lower_pcopy: Set entry->done in the swap loop
We process all the remaining copy entries one-at-a-time when emitting
swaps, so normally we wouldn't need to care about whether the entry is
done, except that we need to look at the other entries to split them up
and we need to skip this when the copy to be split has already been
processed.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5307
Fixes: 0ffcb19b9d9 ("ir3: Rewrite register allocation")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12747>
(cherry picked from commit f5f948826ae47f32e5bfaf46da84b8a1b44f6f7d)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=f842868e32db49eda7ad384e4b0cc14e10ff1be5
Author: Connor Abbott <[email protected]>
Date: Tue Sep 7 11:42:21 2021 +0200
ir3/lower_pcopy: Use right flags for src const/immed
At some point I split up the flags into overall/source flags and made
copies from immed/const only set IR3_REG_IMMED/IR3_REG_CONST on the
source flags, but I forgot to update this. Noticed by inspection.
Fixes: 0ffcb19b9d9 ("ir3: Rewrite register allocation")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12747>
(cherry picked from commit e7f8d283d7c50813e98fda70a52990f3417bc4c6)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=57dad5c2d74893be0cb41ce888a37563d93f79c5
Author: Ed Martin <[email protected]>
Date: Wed Sep 1 10:39:08 2021 -0400
winsys/radeonsi: Set vce_encode = true when VCE found
Allows VA-API encoding on AMD PITCAIRN
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5305
Fixes: 43c04ab2b43 ("radeonsi: separate video hw info based on HW engine
individually")
Reviewed-by: James Zhu <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12679>
(cherry picked from commit 09aeb59b54d8290b02678c9cee588f73377c4762)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=89f35c68f41a20767a6ce2fbd758370f2c0df477
Author: Danylo Piliaiev <[email protected]>
Date: Wed Sep 1 20:21:21 2021 +0300
turnip: re-emit vertex params after they are invalidated
Constants could be invalidated via HLSQ_INVALIDATE_CMD which is
emitted when new pipeline is bound and in CmdClearAttachments.
Also they become invalid after secondary cmd execution.
Fixes geometry flickering in Genshin Impact
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5313
Fixes: 815a85dd7c44f4be4cbf5b351836c921a7a923fd "turnip: do not re-emit
same vs params"
Signed-off-by: Danylo Piliaiev <[email protected]>
Reviewed-by: Emma Anholt <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12684>
(cherry picked from commit 9ab4bfcb535fb45debd1d106da39c73f9aec5770)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=b56bfb8e5feab1f960a8ae50e3e7d54a85c353e0
Author: Ilia Mirkin <[email protected]>
Date: Sun Sep 5 17:58:24 2021 -0400
freedreno: use OUT_WFI for emit_marker
This is only used pre-a5xx, where we want OUT_WFI. Tested on FD420.
Fixes: 8651cfbbf0 (freedreno: emit_marker() cleanup)
Signed-off-by: Ilia Mirkin <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12734>
(cherry picked from commit 5d91cf41f1d81cb1c070ca4edf948d471c9ea911)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=fddc8ddd41306000b8cfe8add69a335821f6b54e
Author: Bas Nieuwenhuizen <[email protected]>
Date: Sat Sep 4 03:32:21 2021 +0200
util/fossilize_db: Don't corrupt keys during entry read.
We change the hash that is still used to set entry->key.
Fixes: d2d642cc014 "util/fossilize_db: Only allocate entries after full
read."
Reviewed-by: Timothy Arceri <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12725>
(cherry picked from commit 8de60a1654a875d0b55512a1508f541f706f9b97)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=1f3067cebfc77198c802049d8205b5faf58f25f4
Author: mattvchandler <[email protected]>
Date: Wed Sep 1 09:44:12 2021 -0800
gallium/osmesa: fix buffer resizing
Generate a new buffer if OSMesaMakeCurrent is called with a new size
Fix a use-after-free error when the old buffer is destroyed
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5276
Fixes: 26c6f6cfbb6 ("gallium/osmesa: Remove the broken buffer-reuse
scheme.")
Reviewed-by: Emma Anholt <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12685>
(cherry picked from commit eed660221b720c5318a7c2e1eb66710e3937e561)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=12ca003fc80045a29971c9b67670ee95743ed136
Author: Mike Blumenkrantz <[email protected]>
Date: Thu Sep 2 15:18:49 2021 -0400
tgsi_to_nir: force int type for LAYER output
this otherwise gets confused as a vec4 most of the time
Cc: [email protected]
Reviewed-by: Timur Kristóf <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12709>
(cherry picked from commit 3b289c9f30e91b329dc8e6d68053ee45b82ef9e9)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=26171c9769d41e7e3421805928ba3072c818f41e
Author: Adrian Bunk <[email protected]>
Date: Thu Aug 26 22:35:49 2021 +0300
util/format: NEON is not available with the soft-float ABI
Fixes: 80923e8d58cc ("util/format: Add some NEON intrinsics-based
u_format_unpack.")
Reviewed-by: Emma Anholt <[email protected]>
Tested-by: Ross Burton <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12569>
(cherry picked from commit 7155676618754acf9ae5350ca2e7da494662cabb)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=27bb508dccee3fc0ec4bd9200f7558a555606337
Author: Marek Olšák <[email protected]>
Date: Tue Aug 24 11:29:31 2021 -0400
radeonsi: disable DCC stores on Navi12-14 for displayable DCC to fix
corruption
This is a hardware limitation.
Fixes: 1d64a1045ea205ee0 "radeonsi: enable dcc image stores on gfx10+"
Reviewed-by: Pierre-Eric Pelloux-Prayer <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12449>
(cherry picked from commit b648d6fbf8c692fda62d40883d7bdc646cdab5ec)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=039fd5c63cd2279c76c6caff604d829fe4031a67
Author: Mike Blumenkrantz <[email protected]>
Date: Tue Aug 31 14:21:30 2021 -0400
zink: destroy shader modules on program free to avoid leaking
it's irrelevant whether the shader pointer is valid, the shader cache
may still exist
Fixes: a92442225ca ("zink: split up shader cache per-stage")
Reviewed-by: Timothy Arceri <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12650>
(cherry picked from commit b7534fe82aa2fd7a4e3fe7695b7b8a4b3d3f23d5)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=a8d20a871e0318cf695b806a15506266f0050a9e
Author: Marek Olšák <[email protected]>
Date: Tue Aug 24 11:49:30 2021 -0400
radeonsi: fix a memory leak in si_get_shader_binary_size
Fixes: bf8a1ca9024 "radeonsi: use the new run-time linker for shaders"
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5272
Reviewed-by: Pierre-Eric Pelloux-Prayer <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12656>
(cherry picked from commit deacef5d43bfa610d5ba7cf10619d8b20b0a0e5e)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=3b028036841bbcfe94f8a7b5cda22808b7870208
Author: Marek Olšák <[email protected]>
Date: Tue Aug 24 12:59:14 2021 -0400
mesa: skip draw calls with unaligned indices
GL doesn't say which error we should report. dEQP expects no error and
no crash and allows skipping the call. Some drivers can crash.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5227
Cc: [email protected]
Acked-by: Pierre-Eric Pelloux-Prayer <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12533>
(cherry picked from commit 6367d8036a261b7b5d0559d680c66697f488ad17)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=b387d54238aae6ef489877d7bcac0d4e4f7cc01b
Author: Marek Olšák <[email protected]>
Date: Tue Aug 24 13:03:30 2021 -0400
mesa: fix gl_DrawID with indirect multi draws using user indirect buffer
The code lowered the draws to direct ones but disregarded gl_DrawID.
We need to pass the draw ID to the driver manually.
gl_DrawID is the 3rd parameter of DrawGallium here.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5274
Cc: [email protected]
Acked-by: Pierre-Eric Pelloux-Prayer <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12533>
(cherry picked from commit 614f273ab4cac46e929c0e688bbf2921b7763560)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=6ce98f2d7d74d04515d5f3d315bc7e57d8b7963b
Author: Marek Olšák <[email protected]>
Date: Tue Aug 24 20:07:08 2021 -0400
mesa: remove unused indices parameter from validate functions
Cc: [email protected]
Reviewed-by: Pierre-Eric Pelloux-Prayer <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12533>
(cherry picked from commit 1f80cd35cbf0f86c943302a10d1c7994002baefd)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=ad3094eac92256c5687ed037359f0990ea80c6bc
Author: Rhys Perry <[email protected]>
Date: Fri Aug 27 17:50:11 2021 +0100
aco: don't constant propagate to DPP instructions
Signed-off-by: Rhys Perry <[email protected]>
Reviewed-by: Timur Kristóf <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12601>
(cherry picked from commit e27946ca110b69be75e999640ffd59fbb45ebe20)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=662d72b770c14634e7533f255a208cc6b203422c
Author: Ian Romanick <[email protected]>
Date: Wed Jul 28 18:16:24 2021 -0700
nir/lower_bit_size: Support add_sat and sub_sat
Without this, lowered saturating ALU instructions would only clamp to
the range of the new type instead of the range of the old type.
v2: Use nir_iclamp. Suggested by Jason. Use new
u_{int,uint}N_{min,max}() helpers.
Fixes: 090e2824079 ("nir: Add a saturated unsigned integer add opcode")
Reviewed-by: Jason Ekstrand <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12142>
(cherry picked from commit 7d8bf7c167d962421d1f8af451b82188357926af)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=4668c70d122b50de239de1fc21915bb9d124908d
Author: Ian Romanick <[email protected]>
Date: Mon Aug 2 16:43:52 2021 -0700
util: Add and use functions to calculate min and max int for a size
Many places need to know the maximum or minimum possible value for a
given size integer... so everyone just open-codes their favorite
version. There is some potential to hit either undefined or
implementation-defined behavior, so having one version that Just Works
seems beneficial.
v2: Fix copy-and-pasted bug (INT64_MAX instead of INT64_MIN) in
u_intmin. Noticed by CI. Lol. Rename functions
`s/u_(uint|int)(min|max)/u_\1N_\2/g`. Suggested by Jason. Add some
unit tests that would have caught the copy-and-paste bug before wasting
CI time. Change the implementation of u_intN_min to use the same
pattern as stdint.h. This avoids the integer division. Noticed by
Jason.
v3: Add changes to convert_clear_color
(src/gallium/drivers/iris/iris_clear.c). Suggested by Nanley.
Reviewed-by: Jason Ekstrand <[email protected]>
Suggested-by: Jason Ekstrand <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12177>
(cherry picked from commit 72259a870f6047c83b3f95ac205aca7ed5bdc049)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=f8f623e44d299ca2024bf25994335b1bf736b903
Author: Quantum <[email protected]>
Date: Sun Aug 15 17:44:04 2021 -0400
main: allow all external textures for BindImageTexture
According to OES_EGL_image_external_essl3:
On p. 196 in the errors section for BindImageTexture, replace the
last error with the following:
"An INVALID_OPERATION error is generated if <texture> is neither the
name of an immutable texture object, nor the name of an external
texture object."
According to OES_EGL_image_external:
The command
void EGLImageTargetTexture2DOES(enum target, eglImageOES image);
with <target> set to TEXTURE_EXTERNAL_OES defines the currently bound
external texture object to be a target sibling of <image>.
...
If <target> is not TEXTURE_EXTERNAL_OES, the error INVALID_ENUM is
generated. (Note: if GL_OES_EGL_image is supported then <target> may
also be TEXTURE_2D).
Currently, mesa only allows GL_TEXTURE_EXTERNAL_OES textures to be bound
by glBindImageTexture. However, the language of the specification does not
appear to use "external" to refer to GL_TEXTURE_EXTERNAL_OES specifically,
since OES_EGL_image_external allows external eglImageOES to be attached
to GL_TEXTURE_2D in the presence of GL_OES_EGL_image. Thus, it should be
interpreted to refer to all types of external textures, including 2D
textures attached via glEGLImageTargetTexture2DOES.
Fixes: ed43dd62acc ("main: allow external textures for BindImageTexture")
Reviewed-by: Marek Olšák <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12383>
(cherry picked from commit e52aa1edffb8552d6215732b00efc85e6188d597)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=bfffc42265fefd4ffb6953a7d4f9888c9a98feb8
Author: Dylan Baker <[email protected]>
Date: Wed Sep 8 09:38:05 2021 -0700
.pick_status.json: Update to 076c8f041a63c74c31d9f541684860628a8b9979
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=2058e98e411e4fc398c278947bcfe2245bb1cb38
Author: liuyujun <[email protected]>
Date: Tue Aug 24 20:34:14 2021 +0800
gallium: fix surface->destroy use-after-free
regen surface on every update framebuffer
Cc: [email protected]
Reviewed-by: Marek Olšák <[email protected]>
Signed-off-by: liuyujun <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12520>
(cherry picked from commit 2bdc0bb324d60546257b250d9a78af1ee61539b8)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=25f91e6ab9c0f1efbcae820f2973b447d01550fb
Author: Lionel Landwerlin <[email protected]>
Date: Mon Aug 30 13:03:26 2021 +0300
intel/fs: fix framebuffer reads
We're missing some restrictions on those messages.
Signed-off-by: Lionel Landwerlin <[email protected]>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5292
Cc: mesa-stable
Reviewed-by: Jordan Justen <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12615>
(cherry picked from commit 838c0e5eefd444df701b6d9cbcef1b06eb5eb207)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=179a29182650286df8e15cbccba04fc894f5df1f
Author: Mike Blumenkrantz <[email protected]>
Date: Mon Aug 30 11:30:46 2021 -0400
zink: free local shader nirs on program free
leak--
Fixes: 61f2667cf5d ("zink: remove gfx program slot mapping")
Reviewed-by: Dave Airlie <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12630>
(cherry picked from commit 441018a173fbeca0eeb5fe532af8c84965331c73)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=29e51b6eb015ced280a496e2b05a92dad04fd595
Author: Mike Blumenkrantz <[email protected]>
Date: Mon Aug 30 10:31:15 2021 -0400
radv: use pool stride when copying single query results
the specified stride is irrelevant for this case since there's only one
result to write
Cc: mesa-stable
Reviewed-by: Bas Nieuwenhuizen <[email protected]>
Reviewed-by: Samuel Pitoiset <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12619>
(cherry picked from commit 90a0556c27c40e3520d645f2512d4596a109c55c)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=808f6e6095b6d69f2eca0ff6664ef13a6578ceed
Author: Neha Bhende <[email protected]>
Date: Fri Aug 27 13:04:20 2021 -0700
svga/drm: use pb_usage_flags instead of pipe_map_flags in
vmw_svga_winsys_buffer_map
This patch basically maps pipe_map_flags to pb_flags. Since we are mapping
it,
STATIC_ASSERTS won't be required.
Fixes: 00c30dad78b0 ("gallium: renumber PIPE_MAP_* enums to remove holes")
Reviewed-by: Charmaine Lee <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12606>
(cherry picked from commit 98fded8a393a944c562cf3d9b103c42022cb821b)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=a02b68ac25212ef53c4c25a791c249200420d43f
Author: Dylan Baker <[email protected]>
Date: Tue Aug 31 09:26:17 2021 -0700
.pick_status.json: Update to f4b61e90617f19ca1b8a3cfe046bac5801081057
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=0ff8559d9f7cd48828fc220c8e82a66bd9ad68a0
Author: Rhys Perry <[email protected]>
Date: Mon Aug 30 10:42:34 2021 +0100
aco: include utility in isel
For std::exchange().
Signed-off-by: Rhys Perry <[email protected]>
Reviewed-by: Timur Kristóf <[email protected]>
Fixes: c1d11bb92c9 ("aco: Add loop creation helpers.")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5301
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12614>
(cherry picked from commit 9df9fe7dfaee84a7152e3d0c0e7bc62db1e5d889)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=e773de69c4c95214a054dc773139ad0b712a0e1c
Author: Timur Kristóf <[email protected]>
Date: Thu Aug 26 13:32:51 2021 +0200
nir: Fix local_invocation_index upper bound for non-compute-like stages.
The lowered LS and NGG stages use local_invocation_index and they
can benefit from the unsigned upper bound because they can emit a
less expensive integer multiplication instruction.
This was working in the past, but accidentally borked by a refactor.
Fossil DB changes on Sienna Cichlid:
Totals from 956 (0.74% of 128647) affected shaders:
CodeSize: 2354172 -> 2344712 (-0.40%)
Instrs: 434359 -> 434327 (-0.01%)
Latency: 1883949 -> 1876814 (-0.38%)
InvThroughput: 762638 -> 757405 (-0.69%)
Fossil DB changes on Sienna Cichlid (with NGGC enabled):
Totals from 57873 (44.99% of 128647) affected shaders:
CodeSize: 155844192 -> 155607064 (-0.15%)
Instrs: 29799184 -> 29799152 (-0.00%)
Latency: 130959764 -> 130814224 (-0.11%); split: -0.11%, +0.00%
InvThroughput: 21100300 -> 20928635 (-0.81%); split: -0.81%, +0.00%
Fixes: 8af6766062044167fb3b61950ddbc7d67e4c3e48
Signed-off-by: Timur Kristóf <[email protected]>
Reviewed-by: Rhys Perry <[email protected]>
Reviewed-by: Jason Ekstrand <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12558>
(cherry picked from commit 548b383310da7e5e29e7c24525a816a45afc26b8)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=13174690794e52fb47350c83e215467306d4f943
Author: Timur Kristóf <[email protected]>
Date: Thu Aug 26 10:47:10 2021 +0200
aco: Unset 16 and 24-bit flags from operands in apply_extract.
Consider the following sequence in a shader:
b = p_extract a
c = v_mad_u32_u16 b, X, 0
The optimizer applies extract, resulting in:
c = v_mad_u32_u16 a, X, 0 (correct)
Then it mistakenly turns that into:
c = v_mul_u32_u24 a, X, 0 (incorrect)
In this case, the p_extract is applied to v_mad_u32_u16 by
apply_extract. After this, we can no longer be sure that
the operands are still 16 or 24-bit, so we have to remove
this flag.
No Fossil DB changes.
Fixes: 54292e99c7844500314bfd623469c65adef954c5
Signed-off-by: Timur Kristóf <[email protected]>
Reviewed-by: Rhys Perry <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12558>
(cherry picked from commit 76b9dd6266f4b170e94ee47a6881c3d528c25969)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=6f312eccb390bdcae197e57acfc325f20a6a1494
Author: Samuel Pitoiset <[email protected]>
Date: Tue Aug 24 16:52:50 2021 +0200
radv: disable DCC image stores on Navi12-14 for displayable DCC corruption
DCC image stores require 128B but 64B is used for displayable DCC.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5265
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5106
Cc: 21.2 mesa-stable
Signed-off-by: Samuel Pitoiset <[email protected]>
Reviewed-by: Bas Nieuwenhuizen <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12521>
(cherry picked from commit 0c550a5fe69271cb01026a3f05d1c918e6552b04)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=30c3079cd0cf749efb194f3ea660906013786451
Author: Timur Kristóf <[email protected]>
Date: Thu Aug 26 16:36:28 2021 +0200
aco: Emit zero for the derivatives of uniforms.
Observed in a shader from Resident Evil Village.
This also helps prevent emitting invalid IR.
Cc: mesa-stable
Signed-off-by: Timur Kristóf <[email protected]>
Reviewed-by: Rhys Perry <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12599>
(cherry picked from commit cfb0d931f27438c1f7c94defa078f2f9454c5a54)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=b104b498a890d747c692b587ce6dfd395d865920
Author: Dylan Baker <[email protected]>
Date: Mon Aug 30 09:40:30 2021 -0700
.pick_status.json: Update to a6a89aaa2f2943532d99d9bc7b80106a1740f237
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=a5abb4eba7f969a9cbeeefaf4fff65b334aff78f
Author: Boris Brezillon <[email protected]>
Date: Tue May 18 16:03:29 2021 +0200
panfrost: v7 does not support RGB32_UNORM textures
Cc: mesa-stable
Fixes: c6bdd976e611 ("panfrost: Split out v6/v7 format tables")
Signed-off-by: Boris Brezillon <[email protected]>
Reviewed-by: Alyssa Rosenzweig <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12588>
(cherry picked from commit 19e29960e92fdf68d647528f0b2f0740376e31b8)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=dc1431d3671d999f9298544f46d0a73709b93ed9
Author: Yevhenii Kharchenko <[email protected]>
Date: Tue Feb 23 00:15:15 2021 +0200
iris: fix layer calculation for TEXTURE_3D ReadPixels() on mip-level>0
Fixes assert when ReadPixels() called to read from FBO to
GL_PIXEL_PACK_BUFFER, on mip-level > 0, since num_layers
wasn't properly calculated with mip-level.
v2: patched 'iris_create_sampler_view' function instead of
'resolve_sampler_views'. Just like it was suggested in this
function's comment.
The logic of fix is similar to one in 'update_image_surface' function
of i965 driver, which is introduced in commit
f9fd0cf4790cb2a530e75d1a2206dbb9d8af7cb2.
With a slight change: setting array_len=1, like it was done in
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/5808 ,
since minifying depth fails KHR-GLES2.texture_3d.filtering tests.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4145
Fixes: 3c979b0e ('iris: add some draw resolve hooks')
Signed-off-by: Yevhenii Kharchenko <[email protected]>
Reviewed-by: Tapani Pälli <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9253>
(cherry picked from commit b9452627730066872af6cf11a3fc390ca29ca242)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=64720c0a3cb8c04864e33abdbbb26188d4f72bc0
Author: Filip Gawin <[email protected]>
Date: Wed Aug 25 23:19:36 2021 +0200
nir: fix ifind_msb_rev by using appropriate type
As you can see comparion "x < 0" doesn't make
sense if x is unsigned.
Fixes: a5747f8a ("nir: add opcodes for *find_msb_rev and lowering ")
Reviewed-by: Gert Wollny <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12548>
(cherry picked from commit 46f3582c6fe607fa30d7ac24d3abd92128855c98)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=1b9a3aa5d78a9ca2337087ff7e6f1f15f6ae2c4c
Author: Filip Gawin <[email protected]>
Date: Tue Aug 24 21:28:19 2021 +0200
nir: fix shadowed variable in nir_lower_bit_size.c
Fixes: 6d792989924 ("nir/lower_bit_size: fix lowering of {imul,umul}_high")
Reviewed-by: Timur Kristóf <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12527>
(cherry picked from commit 9083e9a483696672514c18cec0a91ffd480f0591)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=71a2d809806e5d584aeba8105aaabd17a5687052
Author: Lionel Landwerlin <[email protected]>
Date: Mon Aug 23 16:45:20 2021 +0300
nir: prevent peephole from generating invalid NIR
We can't append instructions following a return/halt instruction
because the control flow helpers will modify the successor of the
block containing the return/halt. And the NIR validator enforces that
the return/halt must have the end of the function as successor.
This tends to happen following lower_shader_calls lowering which
inserts halts. This probably doesn't prevent the optimization, it'll
just happen in one of the return shaders after the halt has been
removed.
v2: Move prev block ending check earlier in the function (Daniel)
Signed-off-by: Lionel Landwerlin <[email protected]>
Reviewed-by: Daniel Schürmann <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12506>
(cherry picked from commit a13e79843e054cc9b35f8f5b8b31fdf28b6ae95d)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=ce5be91818c9a8dd1aca0fe6d41b7ea26b58872e
Author: Timothy Arceri <[email protected]>
Date: Thu Jul 29 15:43:26 2021 +1000
nir: move nir_block_ends_in_break() to nir.h
Will be used in a following commit.
Reviewed-by: Ian Romanick <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12064>
(cherry picked from commit a7f2e683ded4387febd8529bb0a3fa8c691fcce4)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=18581c3a30f33694c29681f205e8878a5e405b94
Author: Ilia Mirkin <[email protected]>
Date: Thu Aug 19 17:59:18 2021 -0400
glsl: fix explicit-location ifc matching in presence of array types
We were treating each field as if it took up a single slot. However
that's not the case. And with strict matching (GLSL 4.20+ / ES 3.1+) we
would end up not matching identical interfaces.
Fixes: c4545676d7 ("glsl/linker: fix location aliasing checks for interface
variables")
Signed-off-by: Ilia Mirkin <[email protected]>
Reviewed-by: Timothy Arceri <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12479>
(cherry picked from commit 18962b94d31d82ae0a697c2afb731f4a447e1b54)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=ad37d530ce545f7f00393f9bc910defb817ccf92
Author: Nanley Chery <[email protected]>
Date: Fri Jul 30 14:31:05 2021 -0700
intel/blorp: Fix Gfx7 stencil surface state valign
Stencil on Gfx7 has a vertical alignment element of 8, but the largest
its surface state can express is 4. Apply the Gfx6 solution of changing
the alignment in blorp_surf_retile_w_to_y.
Cc: mesa-stable
Reviewed-by: Jason Ekstrand <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12132>
(cherry picked from commit c7bcbc950c04367c6abf54cb48ef930557dcea60)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=894627ec890e150498f6e3ccd780873271545041
Author: Alyssa Rosenzweig <[email protected]>
Date: Tue Aug 10 13:41:28 2021 -0400
panfrost: Raise maximum texture size
The hardware can handle much larger textures than we allowed. The game
"Cathedral" requires larger textures for some bizarre reason. Raise the
limit so the game runs, syncing MAX_MIP_LEVELS, the comments, and the CAPs.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Closes: #5203
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12312>
(cherry picked from commit d051b06a484f4fadd6a71cdd580c76ddb93c597f)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=2f1bc2bb60638f064ab5537aa14fbdea9dbabdf9
Author: Timur Kristóf <[email protected]>
Date: Wed Aug 25 12:13:39 2021 +0200
aco: Fix to_uniform_bool_instr when operands are not suitable.
Don't attempt to transform uniform boolean instructions when
their operands are unsuitable. This can happen eg. due to other
optimizations that combine SALU instructions which clear out
the uniform instruction labels.
Cc: mesa-stable
Fixes: 8a32f57fff56b3b94f1b5589feba38016f39427c
Signed-off-by: Timur Kristóf <[email protected]>
Reviewed-by: Daniel Schürmann <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11573>
(cherry picked from commit abcc83e713467ac5f8f8c52da1d3c8e23b696ee5)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=554e47b603f998a67912279f72540d654bdf12b6
Author: Dave Airlie <[email protected]>
Date: Tue Aug 24 22:31:54 2021 -0400
crocus: add missing fs dirty on reduced prim change.
the reduced prim is used to decide some line antialiasing settings.
this fixes mesa-demos antialias
Fixes: f3630548f1da ("crocus: initial gallium driver for Intel gfx 4-7")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12536>
(cherry picked from commit ad786430610f457f299e0085c8ddc4a3fc676553)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=1c89b990a64f4af395527a0ddc21eebabd977508
Author: Dave Airlie <[email protected]>
Date: Tue Aug 24 22:00:47 2021 -0400
crocus: add missing line smooth bits.
Just noticed this in passing.
Fixes: f3630548f1da ("crocus: initial gallium driver for Intel gfx 4-7")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12536>
(cherry picked from commit 6b7a68b7c21eeff1aa037b68b6fb9ab971fe9982)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=be328711105f9c1bb77e74798625922225ee8217
Author: Mike Blumenkrantz <[email protected]>
Date: Tue Aug 24 18:32:17 2021 -0400
zink: fix pipeline caching
this was apparently always broken, but in a very, very subtle way
where the hash table would compare the current pipeline state against
itself instead of using the cache entry's state
Cc: mesa-stable
Reviewed-by: Dave Airlie <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12535>
(cherry picked from commit 560dc4f79076123706559d6d9cff053ce1b77bba)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=47bc609b622b7672178d270a601edd399df77818
Author: Dylan Baker <[email protected]>
Date: Fri Aug 27 09:57:49 2021 -0700
.pick_status.json: Update to 9bc61108d73db4e614dda2a27750ff80165eedbb
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=4489684269989818330f34515168fdcf9abd7f62
Author: Alyssa Rosenzweig <[email protected]>
Date: Tue Aug 17 17:16:54 2021 +0000
panfrost: Replace writers pointer with hash table
This ensures each context can have a separate batch writing a resource
and we don't race trying to flush each other's batches. Unfortunately
the extra hash table operations regress draw-overhead numbers by about
8% but I'd rather eat the overhead and have an obviously correct
implementation than leave known buggy code in tree.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12528>
(cherry picked from commit 8503cab2e0032dd4d4bd1548919d3c359db82547)
Conflicts:
src/gallium/drivers/panfrost/pan_job.c
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=ee6739d4d0aa9ff4c10157bc36e1c1ef57368729
Author: Alyssa Rosenzweig <[email protected]>
Date: Tue Aug 17 17:06:56 2021 +0000
panfrost: Remove writer = NULL assignments
These already happened.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12528>
(cherry picked from commit afebbadda8db4d6b832183ccf95c51a6e117899d)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=57163a984782b49866cbc62bb077d1a165af5f1e
Author: Alyssa Rosenzweig <[email protected]>
Date: Tue Aug 17 16:46:46 2021 +0000
panfrost: Remove rsrc->track.users
No longer needed.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12528>
(cherry picked from commit e7eb28fed0a2f13ef1ca05876c90b3fc9f7243ed)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=a29b083bbe7afe9c2b4571f54c3dec0380201337
Author: Alyssa Rosenzweig <[email protected]>
Date: Tue Aug 17 16:45:17 2021 +0000
panfrost: Prefer batch->resources to rsrc->users
This expresses the semantic of the flush only applying to batches within
the context, not globally, in line with OpenGL's multithreading rules.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12528>
(cherry picked from commit e98aa5541307b28804858c126e1c878c08714bb3)
Conflicts:
src/gallium/drivers/panfrost/pan_job.c
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=22dd50563e2c49df88370a013a778b82d6a3aac3
Author: Alyssa Rosenzweig <[email protected]>
Date: Tue Aug 17 16:40:53 2021 +0000
panfrost: Add foreach_batch iterator
Using the active mask.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12528>
(cherry picked from commit 5c4fbae571f0448897f05399b256d4ca48b3a24b)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=6b788b887048ad4ca763d4adae771060819e84ab
Author: Alyssa Rosenzweig <[email protected]>
Date: Tue Aug 17 16:39:40 2021 +0000
panfrost: Maintain a bitmap of active batches
This is on the context, so no concurrency issues. This will allow us to
efficiently iterate active batches.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12528>
(cherry picked from commit 79dd1a4e634ffd735323da7111f00e9dbda6a354)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=ca3c31add86e802ce8d2fbb95d88de8d97035ff2
Author: Alyssa Rosenzweig <[email protected]>
Date: Tue Aug 17 16:05:07 2021 +0000
panfrost: Cache number of users of a resource
This can be tracked efficiently with atomics, and reduces the places we
use the rsrc->track.users bitmap which has concurrency issues.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12528>
(cherry picked from commit b8da5b1b7f4b5c4663621fae3db319d244e5d0b0)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=2987bf8761ab31c06b6dd26fa63da3ac73dda10d
Author: Alyssa Rosenzweig <[email protected]>
Date: Tue Aug 17 15:59:07 2021 +0000
panfrost: Switch resources from an array to a set
This will help us reduce shared state and simplify multithreading, at
the expense of additional CPU overhead.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12528>
(cherry picked from commit 2f63ccd080342d9f61fdceb983f266972b8a7d97)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=a56b5e1fcd86549abfe2f3c50ae0176931190d01
Author: Alyssa Rosenzweig <[email protected]>
Date: Thu Aug 12 23:25:49 2021 +0000
panfrost: Move bo->label assignment into the lock
We already took the lock, we just unlocked too early. Since the label is
reset in the BO cache, this is racy. Minimal impact in practice but is
still /wrong/ and caught by helgrind.
Fixes: 3fa1f93dace ("panfrost: Label all BOs in userspace")
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12525>
(cherry picked from commit bd15e5e6af898f558267e93797083c4ba5a5b3d2)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=a8c39e9a6880dd6e40330d95b9920d8ba72034f0
Author: Alyssa Rosenzweig <[email protected]>
Date: Thu Aug 12 23:20:44 2021 +0000
panfrost: Don't use ralloc for resources
ralloc is not thread safe, so we cannot use a pipe_screen as a ralloc
context unless we lock the screen. The allocation patterns for resources
are trivial, so just use malloc/calloc/free directly instead of ralloc.
This fixes a segfault in:
dEQP-EGL.functional.sharing.gles2.multithread.random.images.copytexsubimage2d.1
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12525>
(cherry picked from commit e6924be737033a1fa2db6e9a356e53db81bd0079)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=b389e1580c6338fa0c232b0509640db55fc9bfab
Author: Alyssa Rosenzweig <[email protected]>
Date: Thu Aug 12 20:17:48 2021 +0000
panfrost: Protect the variants array with a lock
Without a lock, two threads may bind the same shader CSO simultaneously,
allocate the same variant simultaneously, and then race each other in
the compiler. This manifests in various ways, most commonly failing the
assertion that UBO pushing has only run once. The simple_mtx_t solution
is used in Iris. Fixes the crash in:
dEQP-EGL.functional.sharing.gles2.multithread.simple.buffers.bufferdata_render
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12525>
(cherry picked from commit 40edc87956aac09b60d17eb4e479bcb02b8fa20c)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=e5f2a4a41691d71bae11c22fe451c8fa1cd0be43
Author: Dylan Baker <[email protected]>
Date: Thu Aug 26 10:46:17 2021 -0700
.pick_status.json: Update to 71e748ad2443c373bb090fa1da2626da367b1d20
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=68df13f3cebe8f0fb95d437ade1ae0192e816a9e
Author: Dave Airlie <[email protected]>
Date: Tue Aug 24 02:16:59 2021 -0400
crocus: copy views before adjusting
The current code overwrote the original view which meant if we
had to reemit a surface the second emit would be wrong.
This fixes cubemaps on gm45 and maybe some issues with 3D textures
elsewhere.
Fixes: f3630548f1da ("crocus: initial gallium driver for Intel gfx 4-7")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12514>
(cherry picked from commit 63138c42c5631ecf5d3c8eb3e39e33cac91df4f1)
Conflicts:
src/gallium/drivers/crocus/crocus_state.c
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=ece6458c04e4e2a536afd468a4795b63aff67adc
Author: Alyssa Rosenzweig <[email protected]>
Date: Mon Aug 23 20:18:25 2021 -0400
panfrost: Fix NULL dereference in allowlist code
If a user attempts to run Panfrost on an unsupported GPU (e.g. Mali
T604), Panfrost will refuse to load and will destroy the screen
immediately, allowing for a graceful fallback to a software rasterizer.
However, the screen destroy code calls a screen_destroy function in the
GenXML vtbl -- and this function is still NULL when the allowlist is
checked. This manifests as crashes on unsuported GPUs.
Issue tracked down with Icecream95's mad Ghidra skills.
Closes: #5269
Fixes: 88dc4db6be7 ("panfrost: Init/destroy blitter from per-gen file")
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Reported-by: Icecream95 <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12512>
(cherry picked from commit 2d31d469f771b5ef617c88b8b50dff97288284fe)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=c90937aa10f4c66fe17c20ce568b02e5e33bd6b2
Author: Alyssa Rosenzweig <[email protected]>
Date: Mon Aug 23 13:42:23 2021 -0400
panfrost: Zero initialize blend_shaders
Fixes an invalid read caught by valgrind when there is a hole in the
valid render target mask:
==6749== Conditional jump or move depends on uninitialised value(s)
==6749== at 0x5E88EC0: panfrost_prepare_fs_state (pan_cmdstream.c:417)
==6749== by 0x5E88EC0: panfrost_emit_frag_shader (pan_cmdstream.c:501)
==6749== by 0x5E88EC0: panfrost_emit_frag_shader_meta
(pan_cmdstream.c:573)
==6749== by 0x5E88EC0: panfrost_update_state_fs (pan_cmdstream.c:2593)
==6749== by 0x5E8B0BF: panfrost_direct_draw (pan_cmdstream.c:2839)
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Fixes: a124c47b9f9 ("panfrost: Fix NULL derefs in pan_cmdstream.c")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11383>
(cherry picked from commit 3113dbd83710899c82478646011c1e1832f04fa1)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=0d34c23d37643a9c62185dacc4d9b92998d1d361
Author: Alyssa Rosenzweig <[email protected]>
Date: Fri Jun 11 18:48:09 2021 -0400
pan/mdg: Insert moves before writeout when needed
Otherwise we end up accessing overwritten registers. Fixes
dEQP-GLES31.functional.draw_buffers_indexed.overwrite_common.common_enable_buffer_enable
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11383>
(cherry picked from commit f45ceb818261859e623b45653b55347566c2b8f2)
This seems to have fixed a few additional tests on 21.2:
-
dEQP-GLES31.functional.shaders.opaque_type_indexing.ubo.const_expression_fragment
-
dEQP-GLES31.functional.draw_buffers_indexed.overwrite_indexed.common_separate_blend_func_buffer_separate_blend_func
-
dEQP-GLES31.functional.draw_buffers_indexed.overwrite_common.common_blend_func_buffer_separate_blend_func
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=7c7479e357df8456047b0a99adcb6e64adeeb812
Author: Alyssa Rosenzweig <[email protected]>
Date: Fri Jun 11 18:02:11 2021 -0400
panfrost: Use blendable check for tib read check
These are the same! Either you're blendable and can use f32/f16
conversion, or you're raw and you can only get raw. It's that simple!
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11383>
(cherry picked from commit 2cf581b1956e7ad54606c052bcec1ed0f25419c3)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=0f5b53c848ca869719f0f7b5ee0c60188e59dacc
Author: Alyssa Rosenzweig <[email protected]>
Date: Mon Aug 23 14:53:00 2021 -0400
panfrost: Remove unneeded quirks from T760
Will cause trouble later in the series when we start garbage collecting
unneeded code.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11383>
(cherry picked from commit 6dfdeea213de141f7e6d9d2be22d340087f1729f)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=fd432106c9541eaa4bab3821419b1c3212166be6
Author: Boris Brezillon <[email protected]>
Date: Fri Jun 4 14:41:06 2021 +0200
panfrost: Add explicit padding to pan_blend_shader_key
So the hash function doesn't end up hashing uninitialized values.
Signed-off-by: Boris Brezillon <[email protected]>
Reported-by: Tomeu Vizoso <[email protected]>
Fixes: bbff09b9521f ("panfrost: Move the blend shader cache at the device
level")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11383>
(cherry picked from commit 6b7b8eb0468353ce09a3e305abdc26723d79d3f3)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=b4a7542b5523730ba57717f0e855cb466f757679
Author: Icecream95 <[email protected]>
Date: Sat Aug 14 23:36:27 2021 +1200
pan/bi: Extend bi_add_nop_for_atest for tilebuffer loads
Fixes framebuffer_fetch and blend_equation_advanced dEQP tests on v6.
v2: Use clause dependencies rather than comparing the message type
v3: Shift the BIFROST_SLOT_* constants before using them as a mask
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12375>
(cherry picked from commit 295807e6669025e0c31b78fc0aba276e58cf8dc2)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=9fa11ec3d10c4dbe4ef496e1fb4e6e7b075f94cb
Author: Alyssa Rosenzweig <[email protected]>
Date: Thu Aug 19 22:09:32 2021 +0000
pan/bi: Use CLPER_V6 on Mali G31
Apparently, CLPER_V7 is missing from Mali G31, but CLPER_V6 works. Fixes
INSTR_INVALID_ENC faults and failures in
dEQP-GLES3.functional.shaders.derivate.* on Dvalin.
Technically not an errata but an implementation difference. I suspect
Mali G51 will need this as well, should we ever allowlist it.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12478>
(cherry picked from commit 61c8e39649cad466c7eccfb233d6be3327142452)
Conflicts:
src/panfrost/bifrost/bi_quirks.h
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=9075d635dec2aa9d338cdd9cd87aa779a4d93550
Author: Alyssa Rosenzweig <[email protected]>
Date: Wed Aug 18 22:08:31 2021 +0000
pan/bi: Set the sample ID for blend shader LD_TILE
Use the explicit sample mode and set the sample ID in the pixel indices
structure to the current sample ID. This fixes tilebuffer loads in blend
shaders on multisampled framebuffers.
Make sure the new routine is broken out to a helper for use with ST_TILE
in the next commit.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12478>
(cherry picked from commit 16394dc71a4e78bfeb762ffd05f314b329c17f54)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=62316670798130997a3eed6944ce494f32db02a2
Author: Alyssa Rosenzweig <[email protected]>
Date: Wed Aug 18 22:07:50 2021 +0000
pan/bi: Extract load_sample_id to a helper
Will be reused in the next commit.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12478>
(cherry picked from commit 9f19a883bc536374d38f295f26eadeb3e1a56d47)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=514270a689d509147229e8f96d6a75d77b786e17
Author: Alyssa Rosenzweig <[email protected]>
Date: Wed Aug 18 22:05:17 2021 +0000
pan/bi: Correct the sr_count on +ST_TILE
Otherwise we'll get validator fails when emitting +ST_TILE.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12478>
(cherry picked from commit 5c2a4eb1c241e6eaa91263d6957a7186c58065f0)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=277e0c45a9dae57c3288fb31282a9ddbea9f5a8c
Author: Alyssa Rosenzweig <[email protected]>
Date: Wed Aug 18 21:38:07 2021 +0000
pan/bi: Don't set td in blend shaders
This breaks screen-space derivatives in a shader that uses multiple
render targets, if the derivative calculation is scheduled after a BLEND
instruction calling into a blend shader.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12478>
(cherry picked from commit 710498e424e31ad4f308f52a03338ac30a70271b)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=e3bcce01d985bc301b0204bc781d82f6bd281cc1
Author: Alyssa Rosenzweig <[email protected]>
Date: Fri Aug 13 23:11:39 2021 +0000
panfrost: Disable shader-assisted indirect draws
Although it is passing all of dEQP-GLES31, it is failing a few
KHR-GLES31.* tests. It also has performance issues at the moment. Invert
the existing noindirect debug flag to become a indirect debug flag. Set
this flag for dEQP-GLES31 CI on G52, to make sure the code doesn't bit
rot on the hope someone will pick this up later on.
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12478>
(cherry picked from commit a7f7d741377904a6b69f6826b3dd10bd46b945b0)
Conflicts:
src/gallium/drivers/panfrost/pan_screen.c
src/panfrost/lib/pan_util.h
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=4d3e06e55c9a1a6f6b99ed991f32b4244728bdc6
Author: Alyssa Rosenzweig <[email protected]>
Date: Wed Aug 18 22:16:56 2021 +0000
panfrost: Handle non-dithered clear colours
In b9c095cc2c6 ("panfrost: Rewrite the clear colour packing code"),
packing of clear colours was corrected to use the tilebuffer's
fractional bits, fixing dithering of the clear colour with formats like
RGB565. Unfortunately, that commit did so unconditionally. If the
framebuffer is dithered, but dithering is disabled at the time of
the clear, we would incorrectly dither the clear.
This is a regression, as the old (broken) code passed the relevant CTS
test. What's the catch? Depending on dither state, there are two
formulas to pack tilebuffer colours. We need to handle both. Fixes
KHR-GLES31.core.draw_buffers_indexed.color_masks.
Fixes: b9c095cc2c6 ("panfrost: Rewrite the clear colour packing code")
Signed-off-by: Alyssa Rosenzweig <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12460>
(cherry picked from commit 22538b89b3b25d016f67799519a6554155b345ec)
Conflicts:
src/panfrost/lib/tests/test-clear.c
src/panfrost/vulkan/panvk_cmd_buffer.c
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=12f77679a690333b982c28bbe31eb02aba62457d
Author: Erik Faye-Lund <[email protected]>
Date: Mon Aug 9 08:40:42 2021 +0200
lavapipe: fix reported subpixel precision for lines
We have no reason to report a subpixel precision of 4 for lines; in fact
LLVMpipe uses 8 subpixel bits for lines, similar to other primitives.
But let's use the pipe-cap for this instead of hard-coding it.
Fixes: 9fbf6b2abff ("lavapipe: implement VK_EXT_line_rasterization")
Reviewed-by: Roland Scheidegger <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12277>
(cherry picked from commit a16f3963d36e66e6610c98083595e66712fbb296)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=76d1828b97da2a8fa93ae64d2926750356b24054
Author: Vinson Lee <[email protected]>
Date: Mon Aug 9 15:48:25 2021 -0700
freedreno: Require C++17.
Commit 3a772be026c ("freedreno: Add perfetto renderpass support")
uses C++17 init-statement feature.
GCC
../src/gallium/drivers/freedreno/freedreno_perfetto.cc: In lambda function:
../src/gallium/drivers/freedreno/freedreno_perfetto.cc:148:11: warning:
init-statement in selection statements only available with ‘-std=c++17’ or
‘-std=gnu++17’
148 | if (auto state = tctx.GetIncrementalState();
state->was_cleared) {
| ^~~~
Clang
../src/gallium/drivers/freedreno/freedreno_perfetto.cc:148:11: warning:
'if' initialization statements are a C++17 extension [-Wc++17-extensions]
if (auto state = tctx.GetIncrementalState(); state->was_cleared) {
^
Intel C++ Compiler
../src/gallium/drivers/freedreno/freedreno_perfetto.cc(148): error:
expected a ")"
if (auto state = tctx.GetIncrementalState(); state->was_cleared) {
^
Fixes: 3a772be026c ("freedreno: Add perfetto renderpass support")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5193
Suggested-by: Erik Faye-Lund <[email protected]>
Signed-off-by: Vinson Lee <[email protected]>
Acked-by: Rob Clark <[email protected]>
Acked-by: Erik Faye-Lund <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12293>
(cherry picked from commit 4fc2a6cbdb6fab868a2ee4ee753caa2e83cf6666)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=cc3e149f80b8ea044fff390425f65999983a17b5
Author: Dave Airlie <[email protected]>
Date: Mon Aug 23 13:00:56 2021 +1000
vulkan/wsi/sw: wait for image fence before submitting to queue
With hw devices, when you submit a present, implicit sync will
make sure the work submitted to the gpu on the client will end
up happening before the present work submitted on the server.
However with sw paths there is no real GPU, the lavapipe fake
GPU thread is client side only and presenting is done directly
from the pixmap (or later shared pixmap). In order for this to
make sense the wsi common code should wait for the fence on the
image before queueing the submit to the server so that all
client works has been flushed to the pixmap before the copy or
present operation is submitted.
Fixes: 8004fa9c9501 ("vulkan/wsi: add sw support. (v2)")
Acked-By: Mike Blumenkrantz <[email protected]>
Reviewed-by: Roland Scheidegger <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12502>
(cherry picked from commit 0cddfba3287cab2060c28b05247008bdd1c9905c)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=56f21793decbed3d0d98a4f181d2168829c73316
Author: Samuel Pitoiset <[email protected]>
Date: Mon Aug 9 21:57:41 2021 +0200
radv: fix copying depth+stencil images on compute
Using separate aspects is required.
Fixes few CTS failures (dEQP-VK.api.copy_and_blit.*) when the compute
path is forced in the driver. Note that CTS coverage of compute queue
is rather limited.
Cc: 21.2 mesa-stable
Signed-off-by: Samuel Pitoiset <[email protected]>
Reviewed-by: Bas Nieuwenhuizen <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12287>
(cherry picked from commit be6bdb09182ae53bab28b11bc7219890cdea77b2)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=8f18e97dd737ce4786539ca7179257785a03a77f
Author: Timothy Arceri <[email protected]>
Date: Wed Aug 18 13:57:14 2021 +1000
glsl: fix variable scope for instructions inside case statements
Fixes: 665d75cc5a23 ("glsl: Fix scoping bug in if statements.")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5247
Reviewed-by: Marcin Ślusarz <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12435>
(cherry picked from commit 02b394023b74620092c45734dcdb531e97d6f19d)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=387039e4d06dd3c47a8b62f9331df23b86a7159b
Author: Connor Abbott <[email protected]>
Date: Fri Jul 23 11:59:34 2021 +0200
ir3/ra: Handle huge merge sets
It can happen that we create an enormous merge set, even larger than the
entire register file, in which case find_best_gap() would loop
infinitely. This seems to be triggered more often with
IR3_SHADER_DEBUG=spillall, since it actually happened with a CTS test.
Just bail out in that case.
Fixes: 0ffcb19b9d9 ("ir3: Rewrite register allocation")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12033>
(cherry picked from commit efb34d6ee6af4b51fa3f3f32b7536c4b3de47100)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=8e4d6692f303a0cb55c18f8282f9491992acb74a
Author: Connor Abbott <[email protected]>
Date: Fri Jul 23 11:56:14 2021 +0200
ir3/ra: Fix available bitset for live-through collect srcs
When we mark live-through sources that are merged with the destination
as killed, we kept the bitsets in sync, but we forgot to keep them in
sync when unmarking them after allocating the destination. The result
was that "available" wasn't correct for any instruction afterwards. This
resulted in a bad register allocation with IR3_SHADER_DEBUG=spillall for
a dEQP-VK test.
While we're changing this, use ra_foreach_src().
Fixes: 0ffcb19b9d9 ("ir3: Rewrite register allocation")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12033>
(cherry picked from commit 70c22d38945223fbdef699c8af60f8be95b178c8)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=e64eeb52401a9f93ed0c7d035b5a106ddf83df7d
Author: Jason Ekstrand <[email protected]>
Date: Thu Aug 19 10:51:17 2021 -0500
anv: Set CONTEXT_PARAM_RECOVERABLE to false
We want the kernel to ban our context immediately instead of foolhardily
attempting to recover.
Reviewed-by: Lionel Landwerlin <[email protected]>
Reviewed-by: Kenneth Graunke <[email protected]>
Cc: [email protected]
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12476>
(cherry picked from commit a6a449837b1753a70894a6d532262df2ec0de873)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=f2b61f35386c73b8dee71ddecfa201ce496de276
Author: Dylan Baker <[email protected]>
Date: Tue Aug 24 15:59:03 2021 -0700
.pick_status.json: Update to 572ed2249465acd4c5f8a229d504a48cbddf95a5
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=2a88afe58a225f2200f00141f54aa03b30ce5584
Author: Simon Ser <[email protected]>
Date: Sat Aug 14 14:05:43 2021 +0200
v3d: implement resource_get_param
Prior to this commit, the stride, offset and modifier were fetched
via WINSYS_HANDLE_TYPE_KMS. However we can't make such a query
succeed if the buffer couldn't be imported to the KMS device.
Instead, implement the resource_get_param hook to allow users to
fetch this information without WINSYS_HANDLE_TYPE_KMS.
A tiny helper function is introduced to compute the modifier of a
resource.
Signed-off-by: Simon Ser <[email protected]>
Fixes: 7bcb22363935 ("v3d, vc4: Fix dmabuf import for non-scanout buffers")
Reported-by: Roman Stratiienko <[email protected]>
Reviewed-by: Daniel Stone <[email protected]>
Reviewed-by: Jose Maria Casanova Crespo <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12370>
(cherry picked from commit 8de086e12f5a20a75b227e48faeb83d9aacb21c3)
Conflicts:
src/broadcom/ci/piglit-v3d-rpi4-fails.txt
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=5d99b0869ae369ca0ce5ff22bc12eb2a04727130
Author: Simon Ser <[email protected]>
Date: Sat Aug 14 14:07:28 2021 +0200
vc4: implement resource_get_param
Prior to this commit, the stride, offset and modifier were fetched
via WINSYS_HANDLE_TYPE_KMS. However we can't make such a query
succeed if the buffer couldn't be imported to the KMS device.
Instead, implement the resource_get_param hook to allow users to
fetch this information without WINSYS_HANDLE_TYPE_KMS.
A tiny helper function is introduced to compute the modifier of a
resource.
Signed-off-by: Simon Ser <[email protected]>
Fixes: 7bcb22363935 ("v3d, vc4: Fix dmabuf import for non-scanout buffers")
Reported-by: Roman Stratiienko <[email protected]>
Reviewed-by: Daniel Stone <[email protected]>
Reviewed-by: Jose Maria Casanova Crespo <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12370>
(cherry picked from commit b1fbceac6f840172e2aeae929072ed92a4c47eb0)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=5aa0faf5123a50b5eb3a21cb372d9335cd36bbe2
Author: Simon Ser <[email protected]>
Date: Sat Aug 14 14:03:58 2021 +0200
panfrost: implement resource_get_param
Prior to this commit, the stride, offset and modifier were fetched
via WINSYS_HANDLE_TYPE_KMS. However we can't make such a query
succeed if the buffer couldn't be imported to the KMS device.
Instead, implement the resource_get_param hook to allow users to
fetch this information without WINSYS_HANDLE_TYPE_KMS.
Signed-off-by: Simon Ser <[email protected]>
Fixes: 4c092947df30 ("panfrost: fail in get_handle(TYPE_KMS) without a
scanout resource")
Reported-by: Roman Stratiienko <[email protected]>
Reviewed-by: Daniel Stone <[email protected]>
Reviewed-by: Alyssa Rosenzweig <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12370>
(cherry picked from commit 99fc6f7271c611b58779a0e5c8a7d1764570449d)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=e26269535d0f3a5cf8f0fcc3f0da1e154100522a
Author: Simon Ser <[email protected]>
Date: Sat Aug 14 13:57:15 2021 +0200
etnaviv: add stride, offset and modifier to resource_get_param
Prior to this commit, the stride, offset and modifier were fetched
via WINSYS_HANDLE_TYPE_KMS. However we can't make such a query
succeed if the buffer couldn't be imported to the KMS device.
Instead, extend the resource_get_param hook to allow users to fetch
this information without WINSYS_HANDLE_TYPE_KMS.
Signed-off-by: Simon Ser <[email protected]>
Fixes: 9da901d2b2e7 ("etnaviv: fail in get_handle(TYPE_KMS) without a
scanout resource")
Reported-by: Roman Stratiienko <[email protected]>
Reviewed-by: Lucas Stach <[email protected]>
Reviewed-by: Daniel Stone <[email protected]>
Reviewed-by: Christian Gmeiner <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12370>
(cherry picked from commit b5919b0b106dbdf5f5da6733e83cc532bdf257d8)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=099a7f6ff93559e9935f4276d2be66caa6018062
Author: Erik Faye-Lund <[email protected]>
Date: Tue Aug 17 19:42:21 2021 +0200
gallium/nir/tgsi: initialize file_max for inputs
When this was rewritten to support Vulkan, we stopped initializing
file_max to -1 in the case of no inputs. This causes the draw module
to go down a needlessly pessimistic case, printing an error while we're
at it.
Fixes: 42b5cfdbd26 ("gallivm/nir: fix vulkan vertex inputs")
Reviewed-by: Dave Airlie <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12440>
(cherry picked from commit 63529782d33b4c23282cebd7aef57bd70ff4e3fc)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=33ace70ae1e156baa0b0aea3010865debfe8c9b2
Author: Erik Faye-Lund <[email protected]>
Date: Tue Aug 17 19:41:03 2021 +0200
gallium/nir/tgsi: fixup indentation
This was using mixed tabs and spaces, let's fix that before we start
modifying the code.
Fixes: 42b5cfdbd26 ("gallivm/nir: fix vulkan vertex inputs")
Reviewed-by: default avatarDave Airlie <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12440>
(cherry picked from commit 46746980081a8737b059dfcde7a0fea469837974)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=1a3180d595f6d7541d3931fd63e12cbaec7fe7e7
Author: Ilia Mirkin <[email protected]>
Date: Wed Aug 11 22:26:07 2021 -0400
mesa: don't return errors for gl_* GetFragData* queries
There is nothing in the spec about this. BindFragDataLocation* is
supposed to return an error, but not Get.
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5221
Fixes: 59012c3133 ("mesa: Implement glGetFragDataLocation")
Signed-off-by: Ilia Mirkin <[email protected]>
Reviewed-by: Timothy Arceri <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12333>
(cherry picked from commit bce19b3a779fd3526ef6368bc2fb180da23ba53e)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=fb321556ec37ab85ed6565fe2f3be091a531785f
Author: Dylan Baker <[email protected]>
Date: Thu Aug 19 10:07:49 2021 -0700
.pick_status.json: Update to 8e5e70bb3de7f75ab1b039e2cec2975ba59e4af7
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=fa069379b4753f168170a545221cd03099afac3e
Author: Mike Blumenkrantz <[email protected]>
Date: Tue Aug 17 14:04:16 2021 -0400
nir/lower_vectorize_tess_levels: set num_components for vectorized loads
this otherwise explodes when rewriting e.g., a single array component load
to a vec4
Fixes: f5adf27fb92 ("nir,radv: add and use nir_vectorize_tess_levels()")
fixes zmike/mesa#94
Reviewed-by: Rhys Perry <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12419>
(cherry picked from commit 649251ad4e031609dafd4034b802d292fea6131c)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=1133671ea3b207975c1df761c2c5a6516f7ef1be
Author: Erik Faye-Lund <[email protected]>
Date: Tue Aug 17 15:30:39 2021 +0200
gallivm: fix texture-mapping with 16-bit result
16bit integer support also implies using 16-bit results when sampling
textures.
Because we're returning the results in float SSA values instead of int,
we need to bitcast back to integers before truncating the values.
Fixes: 00ff60f799c ("gallivm: add 16-bit integer support")
Reviewed-by: Roland Scheidegger <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12413>
(cherry picked from commit 45a61f1782561da9a7905bf584cd188d7b108c98)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=8e0d61e1c7ccaaab85ff5e92240b2624c8d6e4f2
Author: Mao, Marc <[email protected]>
Date: Wed Aug 18 07:56:58 2021 +0300
iris: declare padding for iris_vue_prog_key
Otherwise with some compilers/environments (Android) padding
may contain garbage and memcmp of the key will fail.
Cc: mesa-stable
Signed-off-by: Tapani Pälli <[email protected]>
Reviewed-by: Kenneth Graunke <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12438>
(cherry picked from commit fae1e99a15d12b82f65c77c90425335fec7562f1)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=1225326046a5ba3213e3cfc6fd437e1d56c00777
Author: Samuel Pitoiset <[email protected]>
Date: Wed Aug 11 14:06:09 2021 +0200
radv: fix fast clearing depth images with mips on GFX10+
Found by inspection.
Cc: 21.2 mesa-stable
Signed-off-by: Samuel Pitoiset <[email protected]>
Reviewed-by: Bas Nieuwenhuizen <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12325>
(cherry picked from commit b16f3261a71c6fa22e300ba2b65d7e4128d8d05a)
URL:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=22406c6316a51852a96d8f35f0949a2d02014f81
Author: Dylan Baker <[email protected]>
Date: Thu Aug 19 10:07:28 2021 -0700
.pick_status.json: Update to 35c3f5f08b7b11f3896412fb5778f127be329615
