Module: Mesa
Branch: main
Commit: c0142ddf3a0e03499949c594a2b3d162ec257f0d
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=c0142ddf3a0e03499949c594a2b3d162ec257f0d

Author: Emma Anholt <[email protected]>
Date:   Thu Sep 23 17:33:31 2021 -0700

turnip: Disable VK_EXT_display_control.

The common code fails dEQP-VK.wsi.display_control.register_device_event
due to having a stub NOT_IMPLEMENTED return, and thus fails the CTS.  This
is one of our last failures, so disable the extension until it can get
finished off, so we can unblock passing the CTS.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13010>

---

 src/freedreno/ci/deqp-freedreno-a630-fails.txt | 3 ---
 src/freedreno/vulkan/tu_device.c               | 8 +++++++-
 2 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/src/freedreno/ci/deqp-freedreno-a630-fails.txt 
b/src/freedreno/ci/deqp-freedreno-a630-fails.txt
index f43e3612d89..5fee5b05b8d 100644
--- a/src/freedreno/ci/deqp-freedreno-a630-fails.txt
+++ b/src/freedreno/ci/deqp-freedreno-a630-fails.txt
@@ -67,9 +67,6 @@ 
dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.graphics.writes_si
 
dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.graphics.writes_two_buffers_geom,Fail
 
dEQP-VK.spirv_assembly.instruction.graphics.variable_pointers.graphics.writes_two_buffers_vert,Fail
 
-# Broken on all drivers: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4582
-dEQP-VK.wsi.display_control.register_device_event,Fail
-
 # https://gitlab.khronos.org/Tracker/vk-gl-cts/-/issues/3052
 # fixed by https://gerrit.khronos.org/c/vk-gl-cts/+/7837
 
bypass-dEQP-VK.renderpass.suballocation.subpass_dependencies.separate_channels.r8g8b8a8_unorm,Fail
diff --git a/src/freedreno/vulkan/tu_device.c b/src/freedreno/vulkan/tu_device.c
index c97c007975f..5710dc43989 100644
--- a/src/freedreno/vulkan/tu_device.c
+++ b/src/freedreno/vulkan/tu_device.c
@@ -155,7 +155,13 @@ get_device_extensions(const struct tu_physical_device 
*device,
       .KHR_timeline_semaphore = true,
 #endif
 #ifdef VK_USE_PLATFORM_DISPLAY_KHR
-      .EXT_display_control = true,
+      /* This extension is supported by common code across drivers, but it is
+       * missing some core functionality and fails
+       * dEQP-VK.wsi.display_control.register_device_event. Once some variant 
of
+       * https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12305 lands,
+       * then we can re-enable it.
+       */
+      /* .EXT_display_control = true, */
 #endif
       .EXT_external_memory_dma_buf = true,
       .EXT_image_drm_format_modifier = true,

Reply via email to