Module: Mesa Branch: main Commit: 9f8a204645c60f16681309a78ca3a28a276ec5fa URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=9f8a204645c60f16681309a78ca3a28a276ec5fa
Author: Vinson Lee <[email protected]> Date: Sun Dec 19 20:08:37 2021 -0800 panfrost: Avoid double unlock. Fix defect reported by Coverity Scan. Double unlock (LOCK) double_unlock: pthread_mutex_unlock unlocks dev->indirect_draw_shaders.lock while it is unlocked. Fixes: 2e6d94c198e ("panfrost: Add helpers to support indirect draws") Suggested-by: Alyssa Rosenzweig <[email protected]> Signed-off-by: Vinson Lee <[email protected]> Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14262> --- src/panfrost/lib/pan_indirect_draw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/panfrost/lib/pan_indirect_draw.c b/src/panfrost/lib/pan_indirect_draw.c index 9444bd37aec..099e1b120ca 100644 --- a/src/panfrost/lib/pan_indirect_draw.c +++ b/src/panfrost/lib/pan_indirect_draw.c @@ -1168,7 +1168,6 @@ create_indirect_draw_shader(struct panfrost_device *dev, pan_pack(state, RENDERER_STATE, cfg) { pan_shader_prepare_rsd(&shader_info, address, &cfg); } - pthread_mutex_unlock(&dev->indirect_draw_shaders.lock); draw_shader->push = shader_info.push; draw_shader->rsd = dev->indirect_draw_shaders.states->ptr.gpu +
