Module: Mesa
Branch: main
Commit: 269b1232eeeade303181ac906229f9b1c15d96bc
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=269b1232eeeade303181ac906229f9b1c15d96bc

Author: Samuel Pitoiset <[email protected]>
Date:   Fri Feb 25 08:14:25 2022 +0100

radv: remove useless check in radv_cmd_buffer_upload_data()

ptr shouldn't be NULL.

Signed-off-by: Samuel Pitoiset <[email protected]>
Reviewed-by: Bas Nieuwenhuizen <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15164>

---

 src/amd/vulkan/radv_cmd_buffer.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 3fdd75ea14e..fbc0fc320b5 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -647,10 +647,9 @@ radv_cmd_buffer_upload_data(struct radv_cmd_buffer 
*cmd_buffer, unsigned size, c
 
    if (!radv_cmd_buffer_upload_alloc(cmd_buffer, size, out_offset, (void 
**)&ptr))
       return false;
+   assert(ptr);
 
-   if (ptr)
-      memcpy(ptr, data, size);
-
+   memcpy(ptr, data, size);
    return true;
 }
 

Reply via email to