Module: Mesa
Branch: main
Commit: 5831c44121b5ffb897b39ec1411425c427da2259
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=5831c44121b5ffb897b39ec1411425c427da2259

Author: Alyssa Rosenzweig <[email protected]>
Date:   Tue May  3 17:41:23 2022 -0400

panfrost: Relax image check

Shader images on Valhall don't allow nonzero "Minimum level". However,
pan_texture lowers away nonzero minimum levels anyway, so there's nothing to
check. Fixes:

KHR-GLES31.core.shader_image_load_store.advanced-allMips-cs

Signed-off-by: Alyssa Rosenzweig <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16315>

---

 src/gallium/drivers/panfrost/pan_cmdstream.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/src/gallium/drivers/panfrost/pan_cmdstream.c 
b/src/gallium/drivers/panfrost/pan_cmdstream.c
index 82e57afd027..bb0e0c460d7 100644
--- a/src/gallium/drivers/panfrost/pan_cmdstream.c
+++ b/src/gallium/drivers/panfrost/pan_cmdstream.c
@@ -953,16 +953,11 @@ panfrost_emit_images(struct panfrost_batch *batch, enum 
pipe_shader_type stage)
                  *
                  * Similar concerns apply to 3D textures.
                  */
-                if (view.base.target == PIPE_BUFFER) {
+                if (view.base.target == PIPE_BUFFER)
                         view.base.target = PIPE_BUFFER;
-                } else {
+                else
                         view.base.target = PIPE_TEXTURE_2D_ARRAY;
 
-                        /* Hardware limitation */
-                        if (view.base.u.tex.first_level != 0)
-                                unreachable("TODO: mipmaps special handling");
-                }
-
                 panfrost_update_sampler_view(&view, &ctx->base);
                 out[i] = view.bifrost_descriptor;
 

Reply via email to