Module: Mesa
Branch: staging/22.2
Commit: 2c7c5cc016235a3873f62f2c5c55026dc407cde8
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=2c7c5cc016235a3873f62f2c5c55026dc407cde8

Author: Samuel Pitoiset <[email protected]>
Date:   Thu Jul 21 10:13:57 2022 +0200

radv: ignore out-of-order rasterization if stencil write mask is dynamic

This might break out-of-order rasterization on GFX8-GFX9 because it
relies on the stencil write mask which can be dynamic.

Found by inspection.

Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <[email protected]>
Reviewed-by: Bas Nieuwenhuizen <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/17673>
(cherry picked from commit 2012246075abd33751d344a7777f80439e65e7fc)

---

 .pick_status.json              | 2 +-
 src/amd/vulkan/radv_pipeline.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/.pick_status.json b/.pick_status.json
index 0e2d7aa8297..d9715f16159 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -400,7 +400,7 @@
         "description": "radv: ignore out-of-order rasterization if stencil 
write mask is dynamic",
         "nominated": true,
         "nomination_type": 0,
-        "resolution": 0,
+        "resolution": 1,
         "main_sha": null,
         "because_sha": null
     },
diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index 5be524e3bac..2407bd6e3d8 100644
--- a/src/amd/vulkan/radv_pipeline.c
+++ b/src/amd/vulkan/radv_pipeline.c
@@ -972,6 +972,7 @@ radv_pipeline_has_dynamic_ds_states(const struct 
radv_graphics_pipeline *pipelin
                                          RADV_DYNAMIC_DEPTH_WRITE_ENABLE |
                                          RADV_DYNAMIC_DEPTH_COMPARE_OP |
                                          RADV_DYNAMIC_STENCIL_TEST_ENABLE |
+                                         RADV_DYNAMIC_STENCIL_WRITE_MASK |
                                          RADV_DYNAMIC_STENCIL_OP));
 }
 

Reply via email to