Module: Mesa
Branch: main
Commit: 8d8d4347e39eb8e10c33e116f5031864d4f14ede
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=8d8d4347e39eb8e10c33e116f5031864d4f14ede

Author: Chia-I Wu <[email protected]>
Date:   Mon Aug 29 17:01:17 2022 -0700

util/perf: ignore ut->enabled for iterators

With perfetto, instrumentation can be enabled in the middle of cmd
buffer recording even when ut->enabled is false.  It might be better to
be consistent and ignore ut->enabled for iterators.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18309>

---

 src/util/perf/u_trace.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/util/perf/u_trace.c b/src/util/perf/u_trace.c
index c355b0c7da4..bd390b668d0 100644
--- a/src/util/perf/u_trace.c
+++ b/src/util/perf/u_trace.c
@@ -616,9 +616,6 @@ u_trace_has_points(struct u_trace *ut)
 struct u_trace_iterator
 u_trace_begin_iterator(struct u_trace *ut)
 {
-   if (!ut->enabled)
-      return (struct u_trace_iterator) {NULL, NULL, 0};
-
    if (list_is_empty(&ut->trace_chunks))
       return (struct u_trace_iterator) { ut, NULL, 0 };
 
@@ -631,9 +628,6 @@ u_trace_begin_iterator(struct u_trace *ut)
 struct u_trace_iterator
 u_trace_end_iterator(struct u_trace *ut)
 {
-   if (!ut->enabled)
-      return (struct u_trace_iterator) {NULL, NULL, 0};
-
    if (list_is_empty(&ut->trace_chunks))
       return (struct u_trace_iterator) { ut, NULL, 0 };
 

Reply via email to