Module: Mesa
Branch: main
Commit: 4da147a02b541311e8dc231b30dd36fafea820ff
URL:    
http://cgit.freedesktop.org/mesa/mesa/commit/?id=4da147a02b541311e8dc231b30dd36fafea820ff

Author: Pierre-Eric Pelloux-Prayer <[email protected]>
Date:   Thu Sep  8 10:21:32 2022 +0200

mesa: remove fallback for GL_DEPTH_STENCIL

st_TexSubImage has this "default to fallback for depth-stencil" since
2013. I think it's time to remove this limitation - hopefully all
drivers will be happy with the change to avoid adding yet another CAP.

This helps CS:GO startup a lot, because the fallback path is very very
slow.

Reviewed-by: Marek Olšák <[email protected]>
Reviewed-by: Emma Anholt <[email protected]>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/18484>

---

 src/mesa/state_tracker/st_cb_texture.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/src/mesa/state_tracker/st_cb_texture.c 
b/src/mesa/state_tracker/st_cb_texture.c
index 374345b7c6f..2ebe8bbbb0a 100644
--- a/src/mesa/state_tracker/st_cb_texture.c
+++ b/src/mesa/state_tracker/st_cb_texture.c
@@ -1987,12 +1987,6 @@ st_TexSubImage(struct gl_context *ctx, GLuint dims,
       goto fallback;
    }
 
-   /* XXX Fallback for depth-stencil formats due to an incomplete stencil
-    * blit implementation in some drivers. */
-   if (format == GL_DEPTH_STENCIL) {
-      goto fallback;
-   }
-
    /* If the base internal format and the texture format don't match,
     * we can't use blit-based TexSubImage. */
    if (texImage->_BaseFormat !=

Reply via email to